Repository navigation
Allow null contextPath in ServerHttpRequest.Builder - #37099
Closed
garvit-joshi wants to merge 1 commit into
Closed
garvit-joshi wants to merge 1 commit into
garvit-joshi wants to merge 1 commit into
Conversation
The builder method required a non-null contextPath while the underlying field, MutatedServerHttpRequest constructor, and RequestPath.parse all accept null and treat it the same as an empty string. Relax the method parameter to @nullable so callers can clear the context path directly. closes spring-projects#37098 Signed-off-by: Garvit Joshi <garvitjoshi9@gmail.com>
This was referenced Aug 19, 2026
Contributor
|
Fixed via 8d4208f |
pull Bot
pushed a commit
to Clarence404/spring-framework
that referenced
this pull request
Aug 24, 2026
garvit-joshi
added a commit
to garvit-joshi/spring-cloud-gateway
that referenced
this pull request
Oct 4, 2026
ServerHttpRequest.Builder#contextPath accepts null since spring-projects/spring-framework#37099 (Framework 7.1.0-M2), so the context path is cleared with null instead of an empty string. Signed-off-by: Garvit Joshi <garvitjoshi9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #37098