Repository navigation
Add value alias to @ImportGrpcClients - #400
Conversation
Add a `value` attribute to `@ImportGrpcClients` as an alias for `types`, aligning with `@ImportHttpServices` and allowing the shorter form `@ImportGrpcClients(Foo.class)`. Closes: spring-projectsgh-398 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
|
Seems unlikely to braeak anything. I'm still not sure what happens if the target is not specified. |
|
So, I did a little research on this issue. If we refer to the autoconfiguration logic we moved to Spring Boot, we'll see that with default we'll use the default In general, I suggest we think about this. I can suggest the following: We could force a custom target to be specified, whether as a property or an annotation parameter, and if it's not specified, we would return an error log. After that, we could remove the hardcoded code from Spring Boot's autoconfiguration. This would be consistent with the logic behind, for example, This would be the right thing to do, I think, and I can open an issue about it and we can figure out a solution. |
|
This doesn't make sense now, because if the user forgets to specify their URL, they will see an error that the connection to |
Add a
valueattribute to@ImportGrpcClientsas an alias fortypes, aligning with@ImportHttpServicesand allowing the shorter form@ImportGrpcClients(Foo.class).Closes: gh-398