Skip to content

Consider having HeaderWriters check before writing #6454

Closed

Description

@jzheaux

Related to #5193

CacheControlHeaderWriter checks first before writing its corresponding headers.

Since HeaderWriterFilter writes headers at the end of a request, it makes sense that each HeaderWriter implementation would check whether its corresponding headers have already been written before overriding them.

That is, instead of doing:

response.setHeader(name, value)

do:

if (!response.hasHeader(name)) {
    response.setHeader(name, value);
}

Activity

  1. added this to the General Backlog milestone on Jan 17, 2019
  2. ankurpathak commented on Jan 18, 2019

    @ankurpathak
    Contributor

    @jzheaux I will be working on this.

  3. ankurpathak commented on Jan 18, 2019

    @ankurpathak
    Contributor

    Here is a pull request:
    #6456

  4. added a commit that references this issue on Feb 7, 2019
  5. self-assigned this
    on Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: webAn issue in web modules (web, webmvc)type: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions