You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider having HeaderWriters check before writing #6454
CacheControlHeaderWriter checks first before writing its corresponding headers.
Since HeaderWriterFilter writes headers at the end of a request, it makes sense that each HeaderWriter implementation would check whether its corresponding headers have already been written before overriding them.
That is, instead of doing:
response.setHeader(name, value)
do:
if (!response.hasHeader(name)) {
response.setHeader(name, value);
}
Activity
ankurpathak commentedon Jan 18, 2019
@jzheaux I will be working on this.
ankurpathak commentedon Jan 18, 2019
Here is a pull request:
#6456
Polish Formatting in Tests