You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
OAuth2ResourceServer configuration tests use deprecated extractAuthorities #6516
JwtAuthenticationConverter#extractAuthorities was deprecated in #6273 via 0f7dff3.
OAuth2ResourceServerConfigurerTests and OAuth2ResourceServerSpecTests should be updated to no longer use it, changing instead to use setJwtGrantedAuthoritiesConverter.
In OAuth2ResourceServerSpecTests, since the method signature is different from extractAuthorities
what should the implementation changes look like? Can you provide me a starting point as after trying to implement the setJwtGrantedAuthoritiesConverter I am a little lost
Activity
vishalvrv9 commentedon Feb 8, 2019
Hey @jzheaux, haven't completely analyzed the issue but would like to work on it. Can I take this up?
jzheaux commentedon Feb 8, 2019
Yep, it's yours! Feel free to ping me with any questions.
When you are ready to push, check out the contribution guidelines.
jzheaux commentedon Feb 19, 2019
@vishalvrv9 wanted to check in to see how things are going. Are there any questions I can answer for you?
vishalvrv9 commentedon Feb 23, 2019
Hey @jzheaux ,
firstly, apologies for the delay
As per analysis,
OAuth2ResourceServerSpecTests, since the method signature is different fromextractAuthoritieswhat should the implementation changes look like? Can you provide me a starting point as after trying to implement the
setJwtGrantedAuthoritiesConverterI am a little lostjzheaux commentedon Feb 28, 2019
@vishalvrv9 no problem, my apologies for lagging in my response :)
Something like this might work well:
jzheaux commentedon May 14, 2019
@vishalvrv9 Is this something that you'd still like to work on?
vishalvrv9 commentedon May 14, 2019
Hey @jzheaux, Yeah definitely. Apologies lost track of it. Will try submitting a PR as soon as possible.
vishalvrv9 commentedon May 25, 2019
@jzheaux have submitted PR #6904
jzheaux commentedon May 31, 2019
Thanks, @vishalvrv9! I left a bit of feedback in the PR.
vishalvrv9 commentedon Jun 5, 2019
Hey @jzheaux , worked on the feedback a couple of days back.
jzheaux commentedon Jun 12, 2019
Fixed via b6e8997