Skip to content

OAuth2LoginAuthenticationFilter should set AuthenticationDetails #6866

Closed

Description

@ddevrien

Summary

OAuth2LoginAuthenticationFilter is not setting a WebAuthenticationDetails on the OAuth2AuthenticationToken object that is returned. It does set a WebAuthenticationDetails on the authenticationRequest but this instance is lost later on.

I'm doing some post-processing in a AuthenticationSuccessHandler using a custom WebAuthenticationDetails which is currently only working for form login, not for OAuth2 login.

Actual Behavior

AuthenticationDetails is always null when using OAuth2 login

Expected Behavior

An instance of WebAuthenticationDetails is set.

Activity

  1. added
    in: oauth2An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
    and removed on May 15, 2019
  2. rwinch commented on May 15, 2019

    @rwinch
    Member

    Thanks for reaching out @ddevrien! Would you be interested in submitting a Pull Request for this?

  3. ddevrien commented on May 15, 2019

    @ddevrien
    ContributorAuthor

    PR made: #6884
    I'm not really familiar with Github and I wasn't sure how to reference a PR to this issue 😃

  4. changed the title [-]OAuth2LoginAuthenticationFilter not setting WebAuthenticationDetails[/-] [+]OAuth2LoginAuthenticationFilter sets AuthenticationDetails[/+] on May 17, 2019
  5. changed the title [-]OAuth2LoginAuthenticationFilter sets AuthenticationDetails[/-] [+]OAuth2LoginAuthenticationFilter should set AuthenticationDetails[/+] on May 17, 2019
  6. self-assigned this
    on May 17, 2019
  7. added this to the 5.2.0.RC1 milestone on Jun 17, 2019
  8. added a commit that references this issue on Aug 26, 2019
    2876014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: oauth2An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)status: ideal-for-contributionAn issue that we actively are looking for someone to help us withtype: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions