Skip to content

InMemoryUserDetailsManager.updatePassword case-insenstive - #6039

Closed
dperezcabrera wants to merge 1 commit into
spring-projects:masterfrom
dperezcabrera:master
Closed

dperezcabrera wants to merge 1 commit into
spring-projects:masterfrom
dperezcabrera:master

Conversation

@dperezcabrera

Copy link
Copy Markdown
Contributor

When username is not in lowercase It throws a null pointer exception.

@pivotal-issuemaster

Copy link
Copy Markdown

@dperezcabrera Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

Copy link
Copy Markdown

@dperezcabrera Thank you for signing the Contributor License Agreement!

@dperezcabrera dperezcabrera changed the title Fixed bug: when user name is not in lowercase Fix bug: when username is not in lowercase Nov 2, 2018
@rwinch

rwinch commented Nov 8, 2018

Copy link
Copy Markdown
Member

Thanks for the PR @dperezcabrera! Could you please add a test for this?

@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 8, 2018
@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue in: core An issue in spring-security-core labels Nov 8, 2018
@dperezcabrera

Copy link
Copy Markdown
Contributor Author

I would like to add this change to milestone 5.1.2 if possible. Should I change the origin and destination branch to 5.1.x?

@rwinch

rwinch commented Nov 9, 2018

Copy link
Copy Markdown
Member

@dperezcabrera Thanks for the fast turnaround. I have an additional comment on the code. Can you please address that?

If you can fix this issue I mentioned above #6039 (comment), I will be glad to backport the fix.

@dperezcabrera
dperezcabrera force-pushed the master branch 2 times, most recently from c5a9b5f to 56d81fc Compare November 9, 2018 17:05
@rwinch rwinch changed the title Fix bug: when username is not in lowercase InMemoryUserDetailsManager.updatePassword case-insenstive Nov 9, 2018
@rwinch rwinch closed this in 898d005 Nov 9, 2018
@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Nov 9, 2018
@rwinch rwinch self-assigned this Nov 9, 2018
@rwinch rwinch added the type: bug A general bug label Nov 9, 2018
rwinch pushed a commit that referenced this pull request Nov 9, 2018
Previously updatePassword was case sensitive which was
inconsistent with the rest of the class.

This commit updates updatePassword to be case insensitive.

Fixes: gh-6039
@rwinch

rwinch commented Nov 9, 2018

Copy link
Copy Markdown
Member

Thanks for the PR! This is now merged into master and backported to 5.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants