Skip to content

Make CachingUserDetailsService Public - #6196

Merged
rwinch merged 1 commit into
spring-projects:masterfrom
ir73:caching-user-details
Dec 11, 2018
Merged

rwinch merged 1 commit into
spring-projects:masterfrom
ir73:caching-user-details

Conversation

@ir73

@ir73 ir73 commented Nov 30, 2018

Copy link
Copy Markdown
Contributor
  • changed default to public constructor in CachingUserDetailsService

Changed based on the comments in this thread #4139

@pivotal-issuemaster

Copy link
Copy Markdown

@ir73 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

Copy link
Copy Markdown

@ir73 Thank you for signing the Contributor License Agreement!

@rwinch

rwinch commented Nov 30, 2018

Copy link
Copy Markdown
Member

Thank you for the PR @ir73!

Can you please update the commit message to align with the Spring Security conventions?

@ir73

ir73 commented Dec 1, 2018

Copy link
Copy Markdown
Contributor Author

sure, hope it looks better now.

@rwinch rwinch changed the title - moved CachingUserDetailsService to spring-core Make CachingUserDetailsService Public Dec 3, 2018
Made CachingUserDetailsService constructor public and moved to spring-core to make it easier to configure caching in UserDetailsService

Fixes gh-4139
@ir73

ir73 commented Dec 7, 2018

Copy link
Copy Markdown
Contributor Author

@rwinch anything else I could help to get this PR merged?

@rwinch rwinch self-assigned this Dec 11, 2018
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement labels Dec 11, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 11, 2018
@rwinch
rwinch merged commit 9a357f8 into spring-projects:master Dec 11, 2018
@rwinch rwinch added the status: duplicate A duplicate of another issue label Dec 11, 2018
@rwinch

rwinch commented Dec 11, 2018

Copy link
Copy Markdown
Member

@ir73 Thanks for the nudge. Somehow I had missed your comment from the other day. This is now merged into master. Thanks again for your contribution! It is great to see community members like you helping to make Spring better. I hope to see contributions from you again ๐Ÿ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants