Repository navigation
fixes setting paramName only when it is not null - #6332
Conversation
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR @ankurpathak! I have provided feedback inline.
There was a problem hiding this comment.
Please add { to follow Spring Security's code conventions
There was a problem hiding this comment.
Added { to if part.
There was a problem hiding this comment.
Do we need to add it for else part as well??
There was a problem hiding this comment.
Yes. We do not use implied { for one line statements
There was a problem hiding this comment.
Added for else part as well.
There was a problem hiding this comment.
For the test below to work, you need to remove super.
There was a problem hiding this comment.
please rename to lookupVariableWhenParameterNameNullThenNotSet
There was a problem hiding this comment.
renamed test to lookupVariableWhenParameterNameNullThenNotSet
e6a0212 to
dad649d
Compare
rwinch
left a comment
There was a problem hiding this comment.
I just noticed that the commit references an invalid ticket. Can you update it to be Fixes: gh-6223?
dad649d to
7d437a4
Compare
|
changed commit message to reflect Fixes: gh-6223. |
|
Thanks @ankurpathak! This is now merged into master |
Fixes: gh-6223