Skip to content

Improve CsrfBeanDefinitionParser xml parsing - #6451

Merged
rwinch merged 1 commit into
spring-projects:masterfrom
ankurpathak:gh-6423-fix
Jan 22, 2019
Merged

rwinch merged 1 commit into
spring-projects:masterfrom
ankurpathak:gh-6423-fix

Conversation

@ankurpathak

Copy link
Copy Markdown
Contributor

CsrfBeanDefinitionParser registers requestDataValueProcessor
if not already registered

Fixes: gh-6423

@rwinch rwinch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please add a test?

1. CsrfBeanDefinitionParser registers requestDataValueProcessor
if not already registered
2. Created Tests in CsrfBeanDefinitionParserTests

Fixes: spring-projectsgh-6423
@ankurpathak

ankurpathak commented Jan 18, 2019 •

Copy link
Copy Markdown
Contributor Author

Thanks for the PR! Can you please add a test?

@rwinch Test added.

@rwinch rwinch self-assigned this Jan 22, 2019
@rwinch rwinch added type: bug A general bug status: duplicate A duplicate of another issue Namespace labels Jan 22, 2019
@rwinch rwinch added this to the 5.2.0.M2 milestone Jan 22, 2019
@rwinch
rwinch merged commit 2e70d66 into spring-projects:master Jan 22, 2019
@rwinch

rwinch commented Jan 22, 2019

Copy link
Copy Markdown
Member

Thanks this was merged into master and backported via gh-6469 gh-6470 gh-6471

@rwinch rwinch removed in: config An issue in spring-security-config Namespace labels May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML configuration with multiple security:http register multiple requestDataValueProcessor

2 participants