Skip to content

Finer variables for OAuth2 redirectUriTemplate expansion - #6900

Merged
rwinch merged 1 commit into
spring-projects:masterfrom
zeratul021:gh-6239-oauth2-redirect-uri-template-vars
Jun 7, 2019
Merged

rwinch merged 1 commit into
spring-projects:masterfrom
zeratul021:gh-6239-oauth2-redirect-uri-template-vars

Conversation

@zeratul021

Copy link
Copy Markdown

Fixes #6239

Provided baseScheme, baseHost, basePort and basePath variables that comprise the baseUrl variable.
To avoid errors during templating, I've added all variables with empty string default.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 23, 2019
@zeratul021

Copy link
Copy Markdown
Author

@rwinch I've managed to craft something with some assumptions, expecting feedback.

@zeratul021

Copy link
Copy Markdown
Author

@rwinch @jgrandja any feedback guys?

@rwinch rwinch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zeratul021! I added review comments.

Can you also rebase off master since the class has been updated since your PR?

@rwinch rwinch self-assigned this Jun 7, 2019
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Jun 7, 2019
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 7, 2019
@rwinch rwinch added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 7, 2019
@rwinch rwinch added this to the 5.2.0.M3 milestone Jun 7, 2019
@rwinch
rwinch merged commit 7cfb17a into spring-projects:master Jun 7, 2019
@rwinch

rwinch commented Jun 7, 2019

Copy link
Copy Markdown
Member

Thanks for the PR @zeratul021! This is now merged into master

@MPriess

MPriess commented May 25, 2022

Copy link
Copy Markdown
Contributor

What was the initial reason for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scheme/protocol variable for OAuth2 redirectUriTemplate

4 participants