Skip to content

Allow custom ReactiveAuthenticationManager for basic and form auth - #7048

Merged
rwinch merged 1 commit into
spring-projects:masterfrom
ttddyy:gh-5660_auth-manager-override
Jun 28, 2019
Merged

rwinch merged 1 commit into
spring-projects:masterfrom
ttddyy:gh-5660_auth-manager-override

Conversation

@ttddyy

@ttddyy ttddyy commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

I just stumbled upon this issue(#5660), so fixing it.


Prior to this change, HttpBasicSpec#authenticationManager and
FormLoginSpec#authenticationManager were always overridden by
ServerHttpSecurity#authenticationManager.

This commit makes sure override only happens when custom authentication
manager was not specified.

Fixes: gh-5660

Prior to this change, "HttpBasicSpec#authenticationManager" and
"FormLoginSpec#authenticationManager" were always overridden by
"ServerHttpSecurity#authenticationManager".

This commit makes sure override only happens when custom authentication
manager was not specified.

Fixes: spring-projectsgh-5660
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 28, 2019
@rwinch rwinch added type: bug A general bug in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 28, 2019
@rwinch rwinch self-assigned this Jun 28, 2019
@rwinch
rwinch merged commit 7782e29 into spring-projects:master Jun 28, 2019
@rwinch rwinch modified the milestones: 5.2.0.RC1, 5.1.x Jun 28, 2019
@rwinch

rwinch commented Jun 28, 2019

Copy link
Copy Markdown
Member

Thanks for the PR @ttddyy! This is now merged into master and backported via gh-7053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServerHttpSecurity can't set multiple authentication managers

3 participants