[jwortmann]

Always request workspace diagnostics, independently of the "diagnostics_mode" setting.

If we want to do this change, the code at

LSP/plugin/session_buffer.py

Lines 272 to 275 in eab1a17

	def _on_before_destroy(self, view: sublime.View) -> None:
	self.remove_all_inlay_hints()
	if self.has_capability("diagnosticProvider") and self.session.config.diagnostics_mode == "open_files":
	self.session.on_text_document_publish_diagnostics({'uri': self._last_known_uri, 'diagnostics': []})

probably doesn't make sense anymore in that form. But also I think we can't just clear diagnostics unconditionally on closing a file, because that would forfeit the purpose of workspace diagnostics (to have diagnostics for unopened files). So we might need to consider how to handle the problem 2. from #2727 (comment). Maybe another check whether the file is outside of the workspace folders would do.

[netlify]

✅ Deploy Preview for sublime-lsp ready!

Name	Link
🔨 Latest commit	698939a
🔍 Latest deploy log	https://app.netlify.com/projects/sublime-lsp/deploys/69e8cf3551bebe000803fad2
😎 Deploy Preview	https://deploy-preview-2827--sublime-lsp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[jwortmann]

Pull diagnostics are cleared now for files outside of the workspace folders (or for all files if there are no workspace folders), when the file gets closed. I think that should be the expected behavior.

I noticed that the current code with self.has_capability("diagnosticProvider") doesn't work anyway, because that always returns False since the pull diagnostics with multiple providers were fixed (because there is special handling for diagnostic provider registration).

And the diagnostics_mode config setting is now basically reverted to the predecessor setting hide_non_project_diagnostics. Not sure if we also want to revert back to the old name, or leave it like that. But it's probably rarely used anyway.

[rchl]

I have some issue with this configuration's name and values.

"open_files" - All diagnostics reported from the server are shown.
"workspace" - If there are project folders (folders in the side bar),
    diagnostics for files not within those folders are ignored.

"open_files" seem to lost its meaning. It doesn't have to do anything with open files - server might return diagnostics for the whole workspace or just open files.

"workspace" description seems fine but the name of it is not very descriptive (for example could be called "limited_to_workspace" instead).

If we are OK with just completely changing naming around and break backwards compatibility then we could probably come up with better naming. Are we OK with that?

For what it's worth, no servers seem to use it in their default settings.
Of course people might be using it already and would be affected but probably not that many and if it breaks for them nothing really bad will happen. People might just notice and figure out how to fix it.

[jwortmann]

I wonder if we shouldn't just remove this config alltogether, and simply decide for one of the two behaviors, and without it being configurable. I wonder how other editors behave and if the have a config option for this (I assume they don't).

Or we could make it a user setting, because this is not really something specific to the server, but just personal preference. So I'd say it doesn't really make sense to have this as a server-specific config.

[rchl]

I would be fine with user setting that defaults to ignoring diagnostics outside of workspace.

I suppose the setting should then be a hide_non_project_diagnostics boolean like before (or some variation of it).

[jwortmann]

If we want to keep it as part of the server config, we could probably just rename "open_files" to anything else, because that is currently the default value. And that option isn't even referenced anywhere in the source code. The only place left where diagnostics_mode is checked is in

LSP/plugin/core/windows.py

Lines 369 to 374 in 72796d3

	def should_ignore_diagnostics(self, uri: DocumentUri, configuration: ClientConfig) -> str | None:
	scheme, path = parse_uri(uri)
	if scheme != "file":
	return None
	if configuration.diagnostics_mode == "workspace" and not self._workspace.contains(path):
	return "not inside window folders"

---

Another question is what to do about code actions with files outside of the workspace folders, if someone has "diagnostics_mode": "workspace" configured. Because currently, we completely ignore the diagnostics (instead of just not drawing them in the view):

For pull diagnostics, no request is made:

LSP/plugin/session_buffer.py

Lines 620 to 623 in 72796d3

	def do_document_diagnostic_async(self, view: sublime.View, version: int, *, forced_update: bool = False) -> None:
	mgr = self.session.manager()
	if not mgr or mgr.should_ignore_diagnostics(self._last_known_uri, self.session.config):
	return

For publishDiagnostics:

LSP/plugin/core/sessions.py

Lines 1911 to 1914 in 72796d3

	reason = mgr.should_ignore_diagnostics(uri, self.config)
	if isinstance(reason, str):
	debug("ignoring unsuitable diagnostics for", uri, "reason:", reason)
	return

So it's probably useless to automatically request code actions (for current caret position) for such views.

[rchl]

Another question is what to do about code actions with files outside of the workspace folders

your suggestion makes sense to me

[jwortmann]

Yeah but I realized that we actually don't request code actions if there aren't any diagnostics (e.g. if ignored due to outside of workspace folders if configured like that). I have added that logic recently when refactoring the code actions. So it should be fine already.

Perhaps it could be optimized to return early from the function when the file is outside of workspace folders. But that's probably not so important.