Skip to content

Test both TCP modes - #2866

Merged
rwols merged 4 commits into
mainfrom
chore/add-tests
Apr 19, 2026
Merged

rwols merged 4 commits into
mainfrom
chore/add-tests

Conversation

@rwols

@rwols rwols commented Apr 13, 2026

Copy link
Copy Markdown
Member

Add a test that checks that "tcp server mode" works. Server meaning that this plugin acts as the TCP server and the langserver connects as TCP client.

@netlify

netlify Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

βœ… Deploy Preview for sublime-lsp ready!

Name Link
πŸ”¨ Latest commit c511cec
πŸ” Latest deploy log https://app.netlify.com/projects/sublime-lsp/deploys/69e3e31d45829700084081ff
😎 Deploy Preview https://deploy-preview-2866--sublime-lsp.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rwols
rwols force-pushed the chore/add-tests branch from 8d2e9eb to 699dad3 Compare April 13, 2026 21:50
Comment thread tests/server.py Resolved
Comment thread tests/server.py Resolved
Comment thread tests/server.py Resolved
Comment thread tests/setup.py Resolved
Comment thread tests/setup.py Resolved
Comment thread tests/setup.py Resolved

@rchl rchl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve conflicts and fix import linting issues?

Comment thread tests/server.py Resolved
Comment thread tests/server.py Resolved
rwols added 3 commits April 18, 2026 22:00
Add a test that checks that "tcp server mode" works. Server meaning
that this plugin acts as the TCP server and the langserver connects as
TCP client.
@rwols
rwols force-pushed the chore/add-tests branch from b4f0420 to c511cec Compare April 18, 2026 20:01

@rchl rchl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StrEnum is not available in 3.8 and our pyright config specifies 3.8 runtime so enum.StrEnum is an error.

That said, CI doesn't check tests/* so it's only visible in editor when looking at the file.

That's fine for now but ideally we'd move server.py into its own directory and apply different runtime version to it.

@rchl

rchl commented Apr 19, 2026

Copy link
Copy Markdown
Member

Note that I've tried that but defining executionEnvironments and overriding pythonVersion doesn't seem to work.

Previously I've reported microsoft/pyright#11298 which is kind of an opposite issue but I think it's the same problem.

So doesn't seem like we can fix that for now - it's fine to merge as is.

@rwols

rwols commented Apr 19, 2026 •

Copy link
Copy Markdown
Member Author

Yeah. It's just a fake test server for integration tests. Not a big deal to see an error in that file to me. I welcome the effort to make the environment for that file more precise.

@rwols
rwols merged commit 74ddbeb into main Apr 19, 2026
8 checks passed
@rwols
rwols deleted the chore/add-tests branch April 19, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants