Repository navigation
Test both TCP modes - #2866
Test both TCP modes#2866
Conversation
β Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rchl
left a comment
There was a problem hiding this comment.
Can you resolve conflicts and fix import linting issues?
Add a test that checks that "tcp server mode" works. Server meaning that this plugin acts as the TCP server and the langserver connects as TCP client.
rchl
left a comment
There was a problem hiding this comment.
StrEnum is not available in 3.8 and our pyright config specifies 3.8 runtime so enum.StrEnum is an error.
That said, CI doesn't check tests/* so it's only visible in editor when looking at the file.
That's fine for now but ideally we'd move server.py into its own directory and apply different runtime version to it.
|
Note that I've tried that but defining Previously I've reported microsoft/pyright#11298 which is kind of an opposite issue but I think it's the same problem. So doesn't seem like we can fix that for now - it's fine to merge as is. |
|
Yeah. It's just a fake test server for integration tests. Not a big deal to see an error in that file to me. I welcome the effort to make the environment for that file more precise. |
Add a test that checks that "tcp server mode" works. Server meaning that this plugin acts as the TCP server and the langserver connects as TCP client.