Skip to content

remove text decoration on link within kbd in popups - #2909

Merged
rchl merged 1 commit into
mainfrom
fix/popup-kbd-link
May 17, 2026
Merged

rchl merged 1 commit into
mainfrom
fix/popup-kbd-link

Conversation

@rchl

@rchl rchl commented May 17, 2026

Copy link
Copy Markdown
Member

Typescript has a custom feature that allows for expanding hover responses. I want to implement it in LSP-tsgo and I came up with a syntax like <kbd>[+](verbosity:+1)</kbd> which looks bad due to link having an underline:

Screenshot 2026-05-17 at 17 42 20

It looks better with this change:

Screenshot 2026-05-17 at 17 39 26

(I'm injecting this content into the hover response so I can't affect the styles that are used)

@rchl
rchl merged commit 608929e into main May 17, 2026
8 checks passed
@rchl
rchl deleted the fix/popup-kbd-link branch May 17, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants