[rchl]

The text shown when hovering document links was not ideal for unknown schemas. In JSON we've shown "Open in browser" for links with json-schema schema.

Show "Open in browser" only for URIs with http/https schema. For other show "Follow link".

If we don't have target then we don't know schema until resolve and we'll also show "Follow link".

[jwortmann]

IIRC the code at

LSP/plugin/hover.py

Lines 344 to 345 in 608929e

	elif scheme:
	sublime.set_timeout_async(partial(self.try_open_custom_uri_async, uri))

was added later, and at the time when this label was implemented it would always fall back to open unknown links in the browser, that is why the original label was like that.

The fix looks good, but should we maybe adjust the label to Open Link instead of Follow Link?

[rchl]

The fix looks good, but should we maybe adjust the label to Open Link instead of Follow Link?

In that example that I gave, Follow link makes more sense IMO since it's a link to a different position in the same file. But Open link would work too I guess.