[rchl]

I've discovered a bug with saving LSP packages preferences.

After making any change in settings and saving, we'd send workspace/didChangeConfiguration to the server without including project overrides.

To reproduce:

1. Set in project settings:

{
    "settings": {
        "LSP": {
            "LSP-pyright": {
                "settings": {
                    "pyright.dev_environment": "sublime_text"
                }
            }
        }
    }
}

2. Open Preferences: LSP-pyright Settings
3. Change (add/remove) some other key in settings
4. Save

We'd send updated configuration without pyright.dev_environment.

The issue was that we've evaluated whether config has changed too early (in ClientConfigs). We have to let WindowConfigManager evaluate that after merging project overrides and then notify session about changes from within WindowManager.

[jwortmann]

I think there is still another bug that if you modify a server setting in project settings, then the server is restarted (but that also happens on main, so it's not a new bug).

[rchl]

I'll have a look at it next.