Repository navigation
Fix return default on non-existing key - #2967
Merged
Merged
Conversation
Member
|
Makes sense. I'd say the suggested |
Contributor
Author
|
Replaced |
jwortmann
approved these changes
Jun 23, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sublimelsp/LSP-rust-analyzer#218
Feel free to edit as require for style/lint.
I left the
current = current.get(key)alone as I am not sure if changing that tocurrent = current[key]would be considered asunrelated changes.This keep the return None if the value is actually an None value instead of replacing with default as per previous function, pre-7981a13