Repository navigation
Ensure selection start is retained when range formatting - #2993
Merged
Merged
Conversation
Member
|
What effect does this have on other formatters? Have you test-driven a few? |
Member
Author
|
No, I have only tested with Ruff. But unless I missed anything important, I think it should be pretty safe, given that the selection is only modified here if its start point does not match the expected start point anymore. |
Member
|
Let me try with clangd, jdtls, and Roslyn first |
rwols
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2986
Workaround for what I would call a bug in the Ruff formatter, which modifies content outside of the range to format.