Repository navigation
refactor: stricter ListInputItem types - #3036
Merged
Merged
Conversation
rchl
force-pushed
the
fix/list-input-types
branch
from
September 26, 2026 21:15
ced64b7 to
4dfd589
Compare
rchl
force-pushed
the
fix/list-input-types
branch
from
September 26, 2026 21:31
4dfd589 to
e5ab4e0
Compare
This reverts commit d7261ff.
jwortmann
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimented a bit with using https://github.com/SublimeText/sublime-text-stubs stubs. There are various type issues (mostly from the fact that it uses real types for
Valuerather thanAny) but it also implements generic type forsublime.ListInputItemwhich looked like a good idea. Adapt the same approach here so that eventual migration will be easier.