Skip to content

feat: add LspPlugin.on_server_request_async API - #3050

Merged
rwols merged 1 commit into
mainfrom
feat/on_server_request
Oct 4, 2026
Merged

rwols merged 1 commit into
mainfrom
feat/on_server_request

Conversation

@rchl

@rchl rchl commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Implement on_server_request_async API for LspPlugin.

Why not using the request_handler decorator instead? Well, I did in https://github.com/sublimelsp/LSP-kotlin/blob/49f6e674104bd235854b3c4432a73031e1540695/plugin.py#L102-L108 but that means that:

  • I have to now re-implement the logic of the original handler even though I only want to override some parameters passed in the request.
  • The overridden implementation can drift from the actual implementation and break (as it did on asyncio branch due to internal implementation becoming an async function).

With the new API I'm able to override the request params and let LSP handle the request using its own handler.

@netlify

netlify Bot commented Oct 3, 2026

Copy link
Copy Markdown

βœ… Deploy Preview for sublime-lsp ready!

Name Link
πŸ”¨ Latest commit a50b4ce
πŸ” Latest deploy log https://app.netlify.com/projects/sublime-lsp/deploys/6ac16e05353a0b0008425615
😎 Deploy Preview https://deploy-preview-3050--sublime-lsp.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rwols
rwols merged commit 221ab88 into main Oct 4, 2026
9 checks passed
@rwols
rwols deleted the feat/on_server_request branch October 4, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants