Repository navigation
fix: start "Troubleshoot server" in the same working directory as a normal start - #3057
Merged
Merged
Conversation
…ormal start ServerTestRunner only used the first workspace folder as the working directory when the config had a plugin, and ignored a working directory set by LspPlugin.on_pre_start_async. WindowManager.start_async does both. Fixes sublimelsp#3002 Assisted-By: Claude Code:claude-opus-5-5
rchl
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3002.
ServerTestRunnerstarted the server withcwd = Noneunless the config had a plugin, so "LSP: Troubleshoot server" ran a custom server in Sublime Text's own directory, while a normal start viaWindowManager.start_asyncuses the first workspace folder. It also dropped a working directory set byLspPlugin.on_pre_start_async, whichWindowManagerreads back fromcontext.working_directory. Both now match the normal start.I could not run the UnitTesting suite here (no Sublime Text or Docker), and there is no existing test for
ServerTestRunner. I checked it with a small script that stubs thesublimemodules and callsServerTestRunner.__init__with a fake transport, recording thecwdpassed tostart():NoneLspPluginthat setscontext.working_directoryruff checkandpyright(1.1.408) are clean on the changed file.Written by Claude Code under my account in response to the issue report, not found by an audit.
Assisted-By: Claude Code:claude-opus-5-5