Repository navigation
fix: "Troubleshoot server" config handling, working directory and copy button - #3058
Merged
Merged
Conversation
ServerTestRunner passed the window's ClientConfig directly to the plugin's pre-start hooks, so any changes they made to it (command, env, initialization options) stayed in the window's configuration and affected later starts. Work on a copy instead, like WindowManager.start_async does. Also show the working directory the server was started in, so the report can confirm or rule out working-directory problems. Assisted-By: Claude Code:claude-opus-5-5
The link text has been HTML-escaped since 6225b00, so the <kbd> tag inside it showed up as literal text. Wrap the link in <kbd> instead and style it with the sheet's foreground and background colors. Assisted-By: Claude Code:claude-opus-5-5
rwols
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to "LSP: Troubleshoot server":
ServerTestRunnerpassed the window'sClientConfigdirectly to the plugin's pre-start hooks (on_pre_start_async/on_pre_start), so any changes they made to the command, env or initialization options stayed in the window's configuration and affected later starts. It now works on a copy made withClientConfig.from_config(config, {}), likeWindowManager.start_async.<kbd>tag inside it showed up as literal text. The link is now wrapped in<kbd>and styled with the sheet's colors insheets.css.init_optionslabel toinitialization_options.Checked with
tox(pyright and ruff) and by opening the sheet in Sublime Text 4215 in the UnitTesting Docker container (screenshots above). No automated test covers the troubleshoot command.Assisted-By: Claude Code:claude-opus-5-5