Repository navigation
feat: allow disabling the lsp_save key binding with a setting - #3068
Merged
Merged
Conversation
Adds a "disable_lsp_save" setting check to the context of the primary+s key binding so that users or other packages can disable LSP's save override without editing LSP's key bindings. Assisted-By: Claude Code:claude-opus-5-5
β Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rwols
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3017
LSP overrides the
primary+skey binding withlsp_save(required for format-on-save and code-actions-on-save), which conflicts with packages like sublemacspro that use that key for something else.This adds a
setting.disable_lsp_savecontext to the key binding, so the override can be disabled by setting"disable_lsp_save": trueinPreferences.sublime-settings. Since it's a view setting, it can also be set in syntax-specific settings or by another package on specific views only.Documented in the key bindings docs.