Repository navigation
fix: apply all external configs registered within one debounce window - #3075
Merged
Merged
Conversation
When a helper package registers more than one plugin at once (e.g. LSP-R registers "LSP-R" and "rlang"), only the last registered config was passed to WindowConfigManager.update, so the other configs were never applied to open windows until restart. Collect the names registered during the debounce window and update them together. WindowConfigManager.update now accepts a set of config names. Fixes #3074 Assisted-By: Claude Code:claude-opus-5-5
Assisted-By: Claude Code:claude-opus-5-5
Assisted-By: Claude Code:claude-opus-5-5
rwols
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3074
When a helper package registers more than one plugin in the same
plugin_loaded(e.g. LSP-R registersLSP-Randrlang), the debounced notification inClientConfigs.add_external_configonly fired for the last call and passed only that config's name toWindowConfigManager.update. The other configs were never applied to the open windows until Sublime Text was restarted.Changes:
ClientConfigscollects the names of external configs registered during the debounce window and notifies them together.WindowConfigManager.update(andLspSettingsChangeListener.on_client_config_updated) now take a set of config names instead of a single name.Nonestill means "update all configs", so startup still does a single update pass per window.Assisted-By: Claude Code:claude-opus-5-5