Repository navigation
fix: support LocationLink in editor.action.showReferences - #3080
Merged
Merged
Conversation
Assisted-By: Claude Code:claude-opus-5-5
rwols
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client-side handling of the VS Code
editor.action.showReferencescommand assumed its third argument was a list ofLocations: with several results it sorted them bylocation['uri']andlocation['range'], which raises aKeyErrorforLocationLinks. Opening a single result and theLocationPickeralready accept both types, so only the sort key needed to change. It now goes throughget_uri_and_range_from_location, and usesTextPositionin place of the deprecatedPoint.This lets plugins hand any definition-like response to
editor.action.showReferenceswithout converting it first. For example, sublimelsp/LSP-tsgo#15 sends tsgo's source definition result there.Assisted-By: Claude Code:claude-opus-5-5