Repository navigation
feat: add WindowManager.is_session_starting() - #3081
Merged
Merged
Conversation
This was referenced Oct 16, 2026
Member
Author
|
I need to think whether it makes sense to have like a session_name argument... |
Member
Author
|
For its purpose I think it's fine as is. |
rwols
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WindowManager.is_session_starting(), which reports whether a session is being started in the window: the server is being installed, started, or LSP is waiting for the response toinitialize. Such a session isn't returned byget_sessions()yet, so there was no public way to tell that a session is on its way.lsp_smoke_test needs this to end all sessions after a test: a session that is still starting can only be ended once it has started, and if it's left running, it can affect the next test. It currently reads
WindowManager._new_session, which only covers waiting forinitialize, not installing the server, and doesn't exist onfeat/asyncio(see the matching PR for that branch).On
main, a start is in progress while_new_listeneris set, which covers installing, starting and initializing, and further views wait in_pending_listeners.test_sends_did_open_to_multiple_sessionschecks that it'sFalseonce the sessions have started.