Repository navigation
fix: add missing dynamic capability exceptions - #3084
Merged
Merged
Conversation
I've noticed LSP-ruff used to be able to do "Format Selection". But with the latest server version it did not work any more. That's because it now registers the capability via `client/registerCapability`. So it's a dynamic capability now as opposed to a static capability listed in the `initialize` response. The `textDocument/documentRangeFormatting` request did not map to the right capability name. That's why "Format Selection" did not show up any more. Fix by adding the exception to the `_METHOD_TO_CAPABILITY_EXCEPTIONS` dict. Also, add the rest of the missing exceptions.
rchl
reviewed
Oct 18, 2026
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
rchl
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed LSP-ruff used to be able to do "Format Selection". But with the latest server version it did not work any more. That's because it now registers the capability via
client/registerCapability. So it's a dynamic capability now as opposed to a static capability listed in theinitializeresponse.The
textDocument/rangeFormattingrequest did not map to the right capability name. That's why "Format Selection" did not show up any more.Fix by adding the exception to the
_METHOD_TO_CAPABILITY_EXCEPTIONSdict.Also, add the rest of the missing exceptions.