Repository navigation
Multiple examples - #4092
Multiple examples#4092ffissore wants to merge 3 commits into
Conversation
f081390 to
889ad9b
Compare
|
Removed dist files commit and rebased |
|
When is this due to be released? |
|
@theangrydev There are conflicts on this PR @ffissore consider adding some UnitTests |
b4a3246 to
5378801
Compare
|
I've rebased the PR. I'm sorry but I'm not a react dev: all the work has been done by @biggates, I just managed to clean up the code. I don't know where and how to add unit tests. |
3cc992a to
c07a04b
Compare
c07a04b to
690ff6d
Compare
|
why is it not merged? |
|
Hey @JohneDoe if you have some time please add some UnitTests |
|
Can't wait for this to be merged! |
|
Is there anything I can do to help this along? |
690ff6d to
083c355
Compare
|
@havwig I think only UnitTests are needet and merging the new commits. For me its the wrong language. But I'm really interested in this Feature! |
|
See #3803 for related discussion. |
|
What unit tests does this need? Can I do something to help move this along? |
b7044ae to
e8fb25f
Compare
e8fb25f to
6a94c44
Compare
|
Any chance of resolving the conflicts soon? Thanks |
|
Rebased once more, although likely to stop doing so as this PR didn't get enough traction. |
|
If you know react, please add unit tests where appropriate. That will help this PR |
|
@ffissore conceptually, the PR is important to us. The main problem is with the UX and that's something we have to explore and verify before merging anything in. I'm hoping to get some people to help review the UX aspect in a few weeks - this is a bit more challenging than other changes to the UI. |
|
I totally understand your problem and your focus on UX: please keep up the good work. I'll try to keep this in sync with master |
|
This seems to work for multiple request body examples but it doesn't seem to include changes for multiple response examples. Otherwise, we totally want this and I probably could spare a member of my team to work on this if it would be helpful. π |
|
@AndyWendt I have seen it working with multiple examples for both request and response bodies. I built a snapshot and have a live example here: Have a look at one of the POST sections. |
521d97b to
2c82bd7
Compare
|
Interesting @theangrydev, thanks for the insight. I must be doing something wrong then. |
|
Yep, I was. Improper indentation in the yaml file |
|
All hail yaml! King of the whitespace! |
Merged from swagger-api#3616, then collected and re-applied the diff to have a nice git history
β¦a undefined param
2c82bd7 to
7a79c61
Compare
|
The |
|
@theangrydev @AndyWendt However, I still not able to see multiple body examples. |
|
@racci The fix has probably still not been released yet. I compiled my own version of swagger ui with a fix that worked for me. |
|
Ohh I see. Thanks @theangrydev Do you have any estimate when it may release? |
|
@theangrydev @racci i build my Swagger UI of V3.18 by Docker and I download .yaml from your snapshot. It seems mutli-examples still not work yet. I got same result as @racci. |
|
Well, since I am working with this Pull Request for about a few months, I can tell you guys that this is actually working as expected. What can we do to bring this up? |
|
Any progress towards a release? |
|
We have an initial design to what it may end up looking like, but unfortunately no ETA yet. |
|
@ffissore As this worked for me for about a year now, I would like to see this PR rebased against the latest changes so I can update and just re-apply your changes on the latest code. This probably makes life easier for @webron to merge this after they finally decided how they want to style this feature. Sad story that this cannot be merged until the day a final design comes up. I dont see any issue with this and would really love to see this merged. There should be no issue to change the mockup in another release tho. |
|
Apologies @boesing but in the meantime I've left the company so I don't have chances to rebase and test this PR |
|
@ffissore the code changes are in your account? dont understand why you are not able to do this but whatever. I dont see any way to get this even merged then. Hopefully some can take your ideas to apply them in a proper feature in one of the next releases. |

This is a re-work of #3616
All commits made by @biggates were squashed into one commit, put on top of current master (= 3.9.0), and cleaned up so that
npm testpassed3 additional commits were added to clean up the code a bit more, and to remove runtime errors
How Has This Been Tested?
We are about to deploy it to production, but no automatic tests were added
Types of changes
package.json)Checklist: