Skip to content

OAS3 multi examples in requestbody - #3616

Closed
biggates wants to merge 37 commits into
swagger-api:masterfrom
biggates:oas3/multi-examples-in-requestBody
Closed

biggates wants to merge 37 commits into
swagger-api:masterfrom
biggates:oas3/multi-examples-in-requestBody

Conversation

@biggates

Copy link
Copy Markdown

This provides multiple examples in OAS3 examples in requestBody.

@biggates

biggates commented Aug 28, 2017 •

Copy link
Copy Markdown
Author

visual_effect

using OAS3 spec attached here

@biggates

Copy link
Copy Markdown
Author

The rendering of externalValue as a link (<a href="location" target="_blank">) is a bit odd here. Should it be fetched and displayed directly in a <HighlightCode> component ? Maybe only apply to text/* is better?

@webron

webron commented Sep 11, 2017

Copy link
Copy Markdown
Contributor

@biggates thanks for the contribution and sorry for the delayed response. I'd like to take a bit of a closer look into the implementation. This is not exactly what I had in mind for implementing it, though it's definitely a needed solution.

Would you be open to change it based on feedback and also apply the same behavior to responses and regular parameters?

@shockey shockey mentioned this pull request Sep 12, 2017
3 of 22 tasks
@biggates

Copy link
Copy Markdown
Author

Would you be open to change it based on feedback and also apply the same behavior to responses and regular parameters?

@webron Sure, I'm glad to contribute on this.

So this branch will work with 3.2.2
which causes 'There are multiple modules with names that only differ in
casing.'
@shockey

shockey commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

@webron, bump πŸ˜„

@biggates

biggates commented Sep 30, 2017 •

Copy link
Copy Markdown
Author

@shockey I'm still working on this, the current progress looks like this:

image

using the definition https://gist.github.com/biggates/4955d608379a8b1b3224e815c7dd0dc9

I'm not sure whether this is what you have in mind, so I still keep the examples in response as my previous implmentation.

Also the examples in parameters is not finished yet. Maybe I should close this PR for now and re-open one later?

…as3/multi-examples-in-requestBody

# Conflicts:
#	src/core/plugins/oas3/components/index.js
Added support for parameter examples in OAS3.

Known Issues:

* In "Try It Out" mode, all example tabs are redered as "active" and
their values are all displayed
@biggates

biggates commented Nov 1, 2017

Copy link
Copy Markdown
Author

Oops, this breaks RequestBodyEditor. 😭

@galuszkak

Copy link
Copy Markdown

@biggates is it possible to rebase it to the master and merge in near future?

ffissore added a commit to engagetech/swagger-ui that referenced this pull request Jan 9, 2018
Merged from swagger-api#3616, then
collected and re-applied the diff to have a nice git history
@ffissore ffissore mentioned this pull request Jan 10, 2018
3 of 10 tasks
@shockey

shockey commented Feb 10, 2018

Copy link
Copy Markdown
Contributor

Closing in favor of #4092.

@shockey shockey closed this Feb 10, 2018
ffissore pushed a commit to engagetech/swagger-ui that referenced this pull request May 14, 2018
Merged from swagger-api#3616, then
collected and re-applied the diff to have a nice git history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants