Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Spreadsheets with no bounding frame #69

Closed

Description

@jazzido

(as commented in jazzido/tabula#128)

There are spreadsheets with no outer frame.

Proposed fix: build a frame that encloses all the characters in the target area, and use it to clip all the rulings inside it. This, in fact, can be done whether the spreadsheet has a bounding frame or not.

Activity

  1. jeremybmerrill commented on Sep 27, 2014

    @jeremybmerrill
    Member

    picking this up, with this spreadsheet http://www.conab.gov.br/OlalaCMS/uploads/arquivos/13_06_12_10_36_58_boletim_ingles_junho_2013.pdf (I'll find a relevant page and stick it in the test set)

  2. jeremybmerrill commented on Sep 27, 2014

    @jeremybmerrill
    Member

    I implemented this by building the frame to enclose all ruling lines in the target area -- rather than characters. My alternative is more likely to work in all cases for the spreadsheet algorithm, which depends on lines intersecting (or very nearly intersecting).

    Is there a case in which building the frame using characters is superior? Unless I'm mistaken, the "original" method would ignore the frame no matter what, right?

  3. jeremybmerrill commented on Sep 27, 2014

    @jeremybmerrill
    Member

    My solution (33abbdb) causes test_issue78_some_ruling_lines_not_detected to fail. I think the failure is due to a typo fixed in f16eb31 and the new, actual result is a proper result (it basically returns an additional row).

  4. jeremybmerrill commented on Sep 27, 2014

    @jeremybmerrill
    Member

    Can you verify, @jazzido ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions