Repository navigation
Bump UI server to v2.58.1 - #1253
Merged
Merged
Conversation
v2.58.1 fixes the UI loading as a blank page in Chrome 158+ (temporalio/ui#4126): the CSP's 'strict-dynamic' blocked the hashed bootstrap's import() of the entry chunks. ui-server v2.58.1 requires go.temporal.io/api v1.64.0, which renamed temporalnexus.ConvertWorkflowLinkToNexusLink. SDK v1.47.0 still calls the old name, so bump the SDK to v1.49.0, the oldest release compatible with API v1.64.0, and follow its StartActivityOptions.Details -> StaticDetails rename.
|
|
Codex Review Summary: β CompletedThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
chaptersix
approved these changes
Nov 9, 2026
vjymisal0
pushed a commit
to vjymisal0/cli
that referenced
this pull request
Nov 12, 2026
β¦1260) This reverts commit 452d33d / temporalio#1253 and updates to ui-server 2.56.3 which is on api version 1.63.5, includes gomarkdown, go-jose, and x/net for CVE fixes, and includes the html change to fix Chrome 158. Verified with temporal server start-dev: the UI loads in Chrome Beta 158.0.8127.18, and index.html serves script-src 'self' 'sha256-β¦' (no strict-dynamic). Once an OSS server release is on api β₯ 1.64 (server main already is), the CLI can go back to the latest ui-server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
temporalio/ui#4125
What changed?
Bump UI server to v2.58.1.
v2.58.1 fixes the dev server UI loading as a blank page in Chrome 158+, which reaches stable on 2026-11-17 (temporalio/ui#4126). The UI's CSP used
'strict-dynamic'with a hash, and Chrome 158 now blocks the bootstrap'simport()of the entry chunks under that policy.ui-server v2.58.1 requires
go.temporal.io/apiv1.64.0, which pulls in two more changes:go.temporal.io/apiv1.63.5 β v1.64.0. API v1.64.0 renamedtemporalnexus.ConvertWorkflowLinkToNexusLinkβConvertLinkWorkflowToNexusLink, so SDK v1.47.0 no longer compiles against it. This breaks theinternal/temporalclitest build.go.temporal.io/sdkv1.47.0 β v1.49.0, the oldest SDK that uses the new name. v1.49.0 also renamesStartActivityOptions.DetailsβStaticDetails, sobuildStartActivityOptionsis updated to match. The--static-detailsflag behaves the same.Checklist
Stability
Manual tests
Setup
Happy path
The UI response carries the new CSP and still sends
nosniff:This is the same policy that temporalio/ui#4126 verified in Chrome 158. I haven't loaded this CLI build in a Chrome 158 browser myself.
Tests
make testpasses (cliextandgo test ./...).go vet ./...andgofmt -lreport the same pre-existing findings asmain. None are new.