Skip to content

Add a NOT IN operator for KeywordList search attributes - #3961

Merged
rossedfort merged 1 commit into
mainfrom
rossedfort/fe-613-add-not-operator-for-keywordlist-search-attributes
Oct 6, 2026
Merged

rossedfort merged 1 commit into
mainfrom
rossedfort/fe-613-add-not-operator-for-keywordlist-search-attributes

Conversation

@rossedfort

Copy link
Copy Markdown
Contributor

Description & motivation 💭

KeywordList search attributes (BuildIds, TemporalChangeVersion, and any custom one) could be filtered with in, =, !=, is null and is not null, but there was no way to express "this list contains none of these values". != is not a substitute — it compares a single value, so excluding three build IDs meant three separate chips.

Every layer below the UI already handled not in:

  • 'not in' is in the conditionals grammar list in src/lib/utilities/is.ts, and isInConditional matches it.
  • tokenize.ts has a six-character lookahead written specifically to lex it, already covered by a test.
  • formatValue in filter-workflow-query.ts passes the parenthesized literal through unquoted for any in-style conditional.
  • The generic branch of toListWorkflowFilters stores the whole ("a", "b") token as the value and captures not in as the conditional.

So the fix is one entry in listConditionalOptions. The chip's value editor already picks ChipInput vs. a plain input via isInConditional, and applyChanges already re-serializes chips to ("a", "b") for it.

The query serializes unspaced, matching how in is emitted today: `BuildIds`not in("a", "b").

Confirmed server-side support before building this: in common/persistence/visibility/store/query/converter.go, supportedKeywordListOperators is exactly EqualStr, NotEqualStr, InStr, NotInStr. (The List Filter docs page doesn't mention NOT IN, but the converter accepts it.)

Scoped to KeywordList only. Keyword attributes support NOT IN server-side too, but they have no In option in the UI today, so adding Not In there alone would be inconsistent.

The hardcoded English 'In' label moved to a translation key alongside the new 'Not In', so the pair stays consistent.

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Unit: not in serialization (alone and AND-joined) in filter-workflow-query.test.ts; parsing `CustomKeywordListField`not in("Hello", "World") back into a filter (alone and joined) in to-list-workflow-filters.test.ts.

E2E: a KeywordList search attributes block registering a KeywordList custom attribute, covering the Not In flow, the unchanged In flow, and a round trip through the raw query box.

Full unit suite and the integration suite pass; cold svelte-check reports 0 errors; lint:ci is clean.

Manual testing has not been done — nothing here has exercised a real NOT IN query against Elasticsearch. Worth a pass before merge.

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  1. Run the UI against a server with a KeywordList search attribute populated (BuildIds or TemporalChangeVersion).
  2. On the workflows list, Add Filter → pick the KeywordList attribute.
  3. Choose Not In, enter two values, Apply.
  4. The URL should read `BuildIds`not in("a", "b") and the results should exclude matching workflows.
  5. Reload — the chip should rebuild with Not In still selected.
  6. Toggle the raw query box — it should show the same string and re-accept it.

Issue(s) closed

FE-613

@rossedfort
rossedfort requested a review from a team as a code owner September 29, 2026 19:50
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Sep 29, 2026 7:51pm UTC

Request Review

@andrewzamojc andrewzamojc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

const listConditionalOptions = $derived([
{ value: 'in', label: 'In' },
{ value: 'in', label: translate('common.in') },
{ value: 'not in', label: translate('common.not-in') },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is already working and you're just adding it to the FE? All the other files are tests.

@rossedfort
rossedfort merged commit 5c32e40 into main Oct 6, 2026
20 checks passed
@rossedfort
rossedfort deleted the rossedfort/fe-613-add-not-operator-for-keywordlist-search-attributes branch October 6, 2026 16:04
rossedfort added a commit that referenced this pull request Oct 6, 2026
Both conflicts came from FE-613's not in operator (#3961) landing in code this
branch had moved. Its listConditionalOptions change applies to filter-editor,
which now owns that form, and its KeywordList spec selects the list input by an
id the extraction namespaced so two editors can be open at once.
tegan-temporal added a commit that referenced this pull request Oct 13, 2026
Auto-generated version bump from 2.55.0 to 2.56.0

Bump type: minor

Changes included:
- [`c5225d84`](c5225d8) Warn when no Worker is polling the catalog Task Queue (#3982)
- [`14864830`](1486483) wip: namespace picker loading state (#3983)
- [`5c32e401`](5c32e40) feat(filters): add a not in operator for KeywordList search attributes (#3961)
- [`d077ea3e`](d077ea3) Add optional name-row slot to the Nexus form (#3969)
- [`e57e1d97`](e57e1d9) docs: prefer Io components, then Holocene, in CLAUDE.md (#3975)
- [`68f0e07e`](68f0e07) fix(security): stop the API mux honouring X-HTTP-Method-Override (#3960)
- [`b70a7933`](b70a793) Handle partial E2E dependency initialization during teardown (#3950)
- [`01b6163b`](01b6163) Show custom search attribute values in the SAA table (#3987)
- [`c3f5a362`](c3f5a36) [FE-1016] Audit and update Io theme tokens (#3990)
- [`bc80d206`](bc80d20) Improve schedule status pills (#3985)
- [`115f51c9`](115f51c) FE-614 - Quick filter every search attribute value in the configurable tables (#3939)
- [`b6841290`](b684129) a11y(1.4.3): use text-secondary for Combobox loading and no-results text (#3991)
- [`930995fd`](930995f) Compact workflow input and result with preview and fullscreen controls (#3999)
- [`724b9609`](724b960) fix(nexus): show pending message for a running operation's result (#4001)
- [`033a3654`](033a365) Show and filter by event group markers (#3986)
- [`7a54e4ae`](7a54e4a) Update color references to match flatter theme (#4002)
- [`20553483`](2055348) Update go toolchain and deps to address CVEs (#4004)
- [`8d8aa3b2`](8d8aa3b) fix(holocene): destructive buttons look disabled after Io token update (#4000)
- [`e1414cfa`](e1414cf) FE-1009: Render Checkbox description below label, matching RadioInput (#4005)
- [`bc25a40d`](bc25a40) FE-1043: Show schedule action search attributes on detail page (#4010)
- [`c621a6f0`](c621a6f) FE-1027: Show estimated timer fire time on Start To Fire Timeout (#4008)
- [`56d7c808`](56d7c80) add support for mTLS on incoming client connections (#3981)
- [`d7df9e99`](d7df9e9) Stop the SSO sign-in loop for users without permission (#4007)
- [`084fc871`](084fc87) feat(catalog): add slow standalone Nexus operation example and group examples by kind (#4013)
- [`88af5160`](88af516) Fix timeline panel overlapping filter dropdowns (#4015)
- [`63702774`](6370277) Export the demo harness, and let a runner supply its own stages (#3996)
- [`c9337469`](c933746) Stop the history live poll once the workflow closes (#4017)
- [`38936682`](3893668) Share one decode between workflow Input/Result previews (#4019)
- [`e22cb952`](e22cb95) fix(nexus): show operation ID as SANO details card heading (FE-986) (#4021)
- [`4096f825`](4096f82) Show operation state in the SANO Start Attempts section (#4022)
- [`5bf3c533`](5bf3c53) fix(nexus): keep standalone Nexus operation input across long polls (#4014)
- [`561b37b9`](561b37b) Surface the OIDC provider error on the SSO callback (#4018)
- [`7a6058e5`](7a6058e) feat(catalog): filter examples by kind, feature, and source with counts (#4023)

Co-authored-by: tegan-temporal <277832131+tegan-temporal@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — 8e1db7d9 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants