Repository navigation
Add a NOT IN operator for KeywordList search attributes - #3961
Merged
rossedfort merged 1 commit intoOct 6, 2026
Merged
rossedfort merged 1 commit into
rossedfort merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewzamojc
approved these changes
Oct 1, 2026
| const listConditionalOptions = $derived([ | ||
| { value: 'in', label: 'In' }, | ||
| { value: 'in', label: translate('common.in') }, | ||
| { value: 'not in', label: translate('common.not-in') }, |
Contributor
There was a problem hiding this comment.
I guess this is already working and you're just adding it to the FE? All the other files are tests.
rossedfort
deleted the
rossedfort/fe-613-add-not-operator-for-keywordlist-search-attributes
branch
October 6, 2026 16:04
rossedfort
added a commit
that referenced
this pull request
Oct 6, 2026
Both conflicts came from FE-613's not in operator (#3961) landing in code this branch had moved. Its listConditionalOptions change applies to filter-editor, which now owns that form, and its KeywordList spec selects the list input by an id the extraction namespaced so two editors can be open at once.
7 of 8 tasks
tegan-temporal
added a commit
that referenced
this pull request
Oct 13, 2026
Auto-generated version bump from 2.55.0 to 2.56.0 Bump type: minor Changes included: - [`c5225d84`](c5225d8) Warn when no Worker is polling the catalog Task Queue (#3982) - [`14864830`](1486483) wip: namespace picker loading state (#3983) - [`5c32e401`](5c32e40) feat(filters): add a not in operator for KeywordList search attributes (#3961) - [`d077ea3e`](d077ea3) Add optional name-row slot to the Nexus form (#3969) - [`e57e1d97`](e57e1d9) docs: prefer Io components, then Holocene, in CLAUDE.md (#3975) - [`68f0e07e`](68f0e07) fix(security): stop the API mux honouring X-HTTP-Method-Override (#3960) - [`b70a7933`](b70a793) Handle partial E2E dependency initialization during teardown (#3950) - [`01b6163b`](01b6163) Show custom search attribute values in the SAA table (#3987) - [`c3f5a362`](c3f5a36) [FE-1016] Audit and update Io theme tokens (#3990) - [`bc80d206`](bc80d20) Improve schedule status pills (#3985) - [`115f51c9`](115f51c) FE-614 - Quick filter every search attribute value in the configurable tables (#3939) - [`b6841290`](b684129) a11y(1.4.3): use text-secondary for Combobox loading and no-results text (#3991) - [`930995fd`](930995f) Compact workflow input and result with preview and fullscreen controls (#3999) - [`724b9609`](724b960) fix(nexus): show pending message for a running operation's result (#4001) - [`033a3654`](033a365) Show and filter by event group markers (#3986) - [`7a54e4ae`](7a54e4a) Update color references to match flatter theme (#4002) - [`20553483`](2055348) Update go toolchain and deps to address CVEs (#4004) - [`8d8aa3b2`](8d8aa3b) fix(holocene): destructive buttons look disabled after Io token update (#4000) - [`e1414cfa`](e1414cf) FE-1009: Render Checkbox description below label, matching RadioInput (#4005) - [`bc25a40d`](bc25a40) FE-1043: Show schedule action search attributes on detail page (#4010) - [`c621a6f0`](c621a6f) FE-1027: Show estimated timer fire time on Start To Fire Timeout (#4008) - [`56d7c808`](56d7c80) add support for mTLS on incoming client connections (#3981) - [`d7df9e99`](d7df9e9) Stop the SSO sign-in loop for users without permission (#4007) - [`084fc871`](084fc87) feat(catalog): add slow standalone Nexus operation example and group examples by kind (#4013) - [`88af5160`](88af516) Fix timeline panel overlapping filter dropdowns (#4015) - [`63702774`](6370277) Export the demo harness, and let a runner supply its own stages (#3996) - [`c9337469`](c933746) Stop the history live poll once the workflow closes (#4017) - [`38936682`](3893668) Share one decode between workflow Input/Result previews (#4019) - [`e22cb952`](e22cb95) fix(nexus): show operation ID as SANO details card heading (FE-986) (#4021) - [`4096f825`](4096f82) Show operation state in the SANO Start Attempts section (#4022) - [`5bf3c533`](5bf3c53) fix(nexus): keep standalone Nexus operation input across long polls (#4014) - [`561b37b9`](561b37b) Surface the OIDC provider error on the SSO callback (#4018) - [`7a6058e5`](7a6058e) feat(catalog): filter examples by kind, feature, and source with counts (#4023) Co-authored-by: tegan-temporal <277832131+tegan-temporal@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
KeywordList search attributes (
BuildIds,TemporalChangeVersion, and any custom one) could be filtered within,=,!=,is nullandis not null, but there was no way to express "this list contains none of these values".!=is not a substitute — it compares a single value, so excluding three build IDs meant three separate chips.Every layer below the UI already handled
not in:'not in'is in theconditionalsgrammar list insrc/lib/utilities/is.ts, andisInConditionalmatches it.tokenize.tshas a six-character lookahead written specifically to lex it, already covered by a test.formatValueinfilter-workflow-query.tspasses the parenthesized literal through unquoted for any in-style conditional.toListWorkflowFiltersstores the whole("a", "b")token as the value and capturesnot inas the conditional.So the fix is one entry in
listConditionalOptions. The chip's value editor already picksChipInputvs. a plain input viaisInConditional, andapplyChangesalready re-serializes chips to("a", "b")for it.The query serializes unspaced, matching how
inis emitted today:`BuildIds`not in("a", "b").Confirmed server-side support before building this: in
common/persistence/visibility/store/query/converter.go,supportedKeywordListOperatorsis exactlyEqualStr, NotEqualStr, InStr, NotInStr. (The List Filter docs page doesn't mentionNOT IN, but the converter accepts it.)Scoped to KeywordList only. Keyword attributes support
NOT INserver-side too, but they have noInoption in the UI today, so addingNot Inthere alone would be inconsistent.The hardcoded English
'In'label moved to a translation key alongside the new'Not In', so the pair stays consistent.Testing 🧪
How was this tested 👻
Unit:
not inserialization (alone and AND-joined) infilter-workflow-query.test.ts; parsing`CustomKeywordListField`not in("Hello", "World")back into a filter (alone and joined) into-list-workflow-filters.test.ts.E2E: a
KeywordList search attributesblock registering a KeywordList custom attribute, covering the Not In flow, the unchanged In flow, and a round trip through the raw query box.Full unit suite and the integration suite pass; cold
svelte-checkreports 0 errors;lint:ciis clean.Manual testing has not been done — nothing here has exercised a real
NOT INquery against Elasticsearch. Worth a pass before merge.Steps for others to test: 🚶🏽♂️🚶🏽♀️
BuildIdsorTemporalChangeVersion).`BuildIds`not in("a", "b")and the results should exclude matching workflows.Issue(s) closed
FE-613