Skip to content

Allow OnAfterClass listeners to run after AfterClass Configuration Methods - #2865

Merged
krmahadevan merged 1 commit into
testng-team:masterfrom
oliver-hughes:2796_run-onafter-class-after-afterclass
Jan 8, 2023
Merged

krmahadevan merged 1 commit into
testng-team:masterfrom
oliver-hughes:2796_run-onafter-class-after-afterclass

Conversation

@oliver-hughes

Copy link
Copy Markdown
Contributor

Fixes #2796

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.


Code change & Tests to allow specifying ordering of @afterclass and onAfterClass methods to be same as current or symmetrical to @beforeClass and onBeforeClass

I've left current behaviour as default to avoid breaking existing usage.

@krmahadevan
krmahadevan merged commit 8634720 into testng-team:master Jan 8, 2023
@krmahadevan

Copy link
Copy Markdown
Member

@oliver-hughes - Thank You so much for taking the time to help raise a PR to fix this issue. The PR stands merged and will be available in the upcoming release of TestNG. Looking forward to more such contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listener's onAfterClass is called before @AfterClass configuration methods are executed.

3 participants