Skip to content

Bobshie beforeconfig skip - #2881

Merged
krmahadevan merged 4 commits into
testng-team:masterfrom
bobshie:bobshie-beforeconfig-skip
Mar 14, 2023
Merged

krmahadevan merged 4 commits into
testng-team:masterfrom
bobshie:bobshie-beforeconfig-skip

Conversation

@bobshie

@bobshie bobshie commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Fixes #2880 .

Did you remember to?

  • [*] Add test case(s)
  • [*] Update CHANGES.txt
  • [*] Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

bobshie added 3 commits March 10, 2023 13:32
Signed-off-by: Bob Shi <bob.shi@ericsson.com>
Signed-off-by: Bob Shi <bob.shi@ericsson.com>
Signed-off-by: Bob Shi <bob.shi@ericsson.com>

@krmahadevan krmahadevan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have shared some comments

@juherr juherr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm once approved by @krmahadevan

@Hkh9966

Hkh9966 commented Mar 13, 2023 •

Copy link
Copy Markdown

image
@krmahadevan One UT failed, but it doesn't seem to be related to this change. Can we skip it or relaunch UT again?

Signed-off-by: Bob Shi <bob.shi@ericsson.com>
@krmahadevan
krmahadevan merged commit 8b5f4d1 into testng-team:master Mar 14, 2023
@juherr juherr added this to the 7.8.0 milestone Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

before configuration and before invocation should be 'SKIP' when beforeMethod is 'skip'

4 participants