Repository navigation
GITHUB-2765: Propagate timeout stack trace to fix testng-team#2765 - #3206
Conversation
WalkthroughThe pull request updates the TestNG framework from version 7.11.0 to 7.12.0. The primary change is related to error handling for test timeouts. Enhancements in the Changes
Sequence Diagram(s)sequenceDiagram
participant Test as TimeoutStacktraceTest
participant Helper as MethodInvocationHelper
participant Exception as ThreadTimeoutException
Test->>Helper: Invoke test method (with/without executor)
Helper->>Exception: Timeout occurs, create exception with cause
Exception-->>Helper: Exception constructed and propagated
Helper-->>Test: Exception caught and processed
Test->>Test: Analyze causal chain for stack trace
Poem
π Recent review detailsConfiguration used: CodeRabbit UI π Files selected for processing (4)
β Files skipped from review due to trivial changes (1)
π Additional comments (7)
β¨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #2765 .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.
Summary by CodeRabbit
Bug Fixes
Tests
Chores