Skip to content

feat: Remove obsolete lcobucci/clock depdendency - #1505

Merged
Sephster merged 1 commit into
thephpleague:masterfrom
mitelg:feat/remove-clock-dependency
Jun 25, 2026
Merged

feat: Remove obsolete lcobucci/clock depdendency#1505
Sephster merged 1 commit into
thephpleague:masterfrom
mitelg:feat/remove-clock-dependency

Conversation

@mitelg

@mitelg mitelg commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Hey there πŸ‘‹

We are currently using this library in our projects. As we have a full Symfony stack, we currently have two clock implementations in our vendor directory: lcobucci/clock and symfony/clock.

As indicated in this issue #1489, PSR interface are there to prevent such cases.

There is only one place where the lcobucci/clock is used and as @eugene-borovov stated here #1489 (comment) this could easily be replaced with an inline anonymous class implementation of the ClockInterface.

I am looking for feedback.
Best regards ✌️

@mitelg
mitelg force-pushed the feat/remove-clock-dependency branch from 32e586c to a277225 Compare April 15, 2026 09:13
@mitelg
mitelg force-pushed the feat/remove-clock-dependency branch from a277225 to 330a4c2 Compare April 15, 2026 09:15
@eugene-borovov

Copy link
Copy Markdown
Contributor

Currently, two libraries in my project require different versions of lcobucci/clock. However, there is no need for it. I have to patch these libraries in a similar way to avoid conflicts in the project. Unfortunately, the maintainers of these libraries refuse to consider the possibility of removing lcobucci/clock.

I hope your PR will be accepted.

@mitelg

mitelg commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

@eugene-borovov I saw that the issue was closed and I understand if the maintainers don't want to do the work as it works how it is.
But nobody created a PR for it before, so imo this is a bit different now πŸ™‚ The reasoning for removing is there, the work was done, so now let's see πŸ˜‰

@mitelg

mitelg commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

hey @Sephster

I don't want to annoy you, but did you have the chance to have a look at this in the meantime? πŸ™‚

@Sephster Sephster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Happy to merge. Thanks for this

@Sephster
Sephster merged commit b79417f into thephpleague:master Jun 25, 2026
27 checks passed
@mitelg

mitelg commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

thanks for merging ✌️

@mitelg
mitelg deleted the feat/remove-clock-dependency branch June 25, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants