feat: Remove obsolete lcobucci/clock depdendency - #1505
Conversation
32e586c to
a277225
Compare
a277225 to
330a4c2
Compare
|
Currently, two libraries in my project require different versions of lcobucci/clock. However, there is no need for it. I have to patch these libraries in a similar way to avoid conflicts in the project. Unfortunately, the maintainers of these libraries refuse to consider the possibility of removing lcobucci/clock. I hope your PR will be accepted. |
|
@eugene-borovov I saw that the issue was closed and I understand if the maintainers don't want to do the work as it works how it is. |
|
hey @Sephster I don't want to annoy you, but did you have the chance to have a look at this in the meantime? π |
Sephster
left a comment
There was a problem hiding this comment.
This looks great. Happy to merge. Thanks for this
|
thanks for merging βοΈ |
Hey there π
We are currently using this library in our projects. As we have a full Symfony stack, we currently have two clock implementations in our vendor directory:
lcobucci/clockandsymfony/clock.As indicated in this issue #1489, PSR interface are there to prevent such cases.
There is only one place where the
lcobucci/clockis used and as @eugene-borovov stated here #1489 (comment) this could easily be replaced with an inline anonymous class implementation of the ClockInterface.I am looking for feedback.
Best regards βοΈ