Malformed installpkg artifact raises an internal error #4230

#!/usr/bin/env python3
import os
import shutil
import subprocess
import sys
from pathlib import Path

REPRO_D = Path("/tmp/repro.d")
work = Path("/tmp/installpkg-malformed")
shutil.rmtree(work, ignore_errors=True)
artifacts = work / "artifacts"
artifacts.mkdir(parents=True)


def tox_run_installpkg(artifact):
    project = work / f"project-{artifact}"
    project.mkdir()
    shutil.copy(REPRO_D / "tox.toml", project)
    tox = subprocess.run(
        ["/opt/venv/bin/tox", "run", "-e", "a", "--installpkg", artifacts / artifact],
        cwd=project,
        env={**os.environ, "PIP_NO_INDEX": "1"},  # pip is never reached here; if it were, fail instead of going online
        capture_output=True,
        text=True,
        timeout=120,
    )
    print(f"--- tox run -e a --installpkg {artifact}  ->  exit code {tox.returncode}")
    return tox.returncode, (tox.stdout + tox.stderr).splitlines()


# the artifact producer's part
subprocess.run([sys.executable, REPRO_D / "make_malformed_artifacts.py", artifacts], check=True)

# reference: the malformed wheel tox does check for is rejected as "a: failed with <reason>", exit code 1
_, lines = tox_run_installpkg("no_dist_info-1.0-py3-none-any.whl")
print("\n".join(lines))

# trigger: each of these lets a parse error escape from extract_install_info()
escaping_exception = {
    "bad_requires-1.0-py3-none-any.whl": "packaging.requirements.InvalidRequirement",
    "no_metadata-1.0-py3-none-any.whl": "importlib.metadata.MetadataNotFound",
    "not_a_zip-1.0-py3-none-any.whl": "zipfile.BadZipFile",
    "not_gzip-1.0.tar.gz": "tarfile.ReadError",
    "no_members-1.0.tar.gz": "StopIteration",
}
reported_as_internal_error = []
for artifact, exception in escaping_exception.items():
    code, lines = tox_run_installpkg(artifact)
    frame = [line for line in lines if line.endswith("in extract_install_info")]
    raised = [line for line in lines if line.startswith(exception)]
    print("\n".join(line for line in lines if line.lstrip().startswith("a:") or line in frame + raised))
    if code == 2 and "a: internal error" in lines and frame and raised:
        reported_as_internal_error.append(artifact)

# check: a rejected artifact must give "a: failed with <reason>" and exit code 1, not an internal error and a traceback
print()
print("reported as tox internal error:", reported_as_internal_error)
print("BUG" if reported_as_internal_error else "OK")

#!/usr/bin/env python3
import sys
import tarfile
import zipfile
from pathlib import Path

out = Path(sys.argv[1])

with zipfile.ZipFile(out / "bad_requires-1.0-py3-none-any.whl", "w") as wheel:
    wheel.writestr(
        "bad_requires-1.0.dist-info/METADATA",
        "Metadata-Version: 2.1\nName: bad_requires\nVersion: 1.0\nRequires-Dist: requests => 2.0\n",  # "=>" is no operator
    )

with zipfile.ZipFile(out / "no_metadata-1.0-py3-none-any.whl", "w") as wheel:
    wheel.writestr("no_metadata-1.0.dist-info/WHEEL", "Wheel-Version: 1.0\n")

(out / "not_a_zip-1.0-py3-none-any.whl").write_bytes(b"not a zip archive\n")

(out / "not_gzip-1.0.tar.gz").write_bytes(b"not a gzip stream\n")

with tarfile.open(out / "no_members-1.0.tar.gz", "w:gz"):
    pass

# the one malformed wheel tox does check for
with zipfile.ZipFile(out / "no_dist_info-1.0-py3-none-any.whl", "w") as wheel:
    wheel.writestr("no_dist_info/__init__.py", "")