Repository navigation
Description
With NullAway:JSpecifyMode=true, NullAway 0.13.8 crashes javac with an internal
NullPointerException on an ordinary JUnit assertThrows idiom.
Versions: NullAway 0.13.8, Error Prone 2.50.0, JDK 25.0.1, Gradle 9.6.1,
net.ltgt.errorprone 5.1.0, JUnit 6.0.3, JSpecify 1.0.0.
Reproducer
Deterministic (3/3 from a cold daemon with no build dir). Three source files in one @NullMarked
package, compiled as one batch.
build.gradle:
plugins {
id 'java'
id 'net.ltgt.errorprone' version '5.1.0'
}
repositories { mavenCentral() }
java {
toolchain { languageVersion = JavaLanguageVersion.of(25) }
}
dependencies {
testCompileOnly 'org.jspecify:jspecify:1.0.0'
testImplementation 'org.junit.jupiter:junit-jupiter-api:6.0.3'
errorprone 'com.google.errorprone:error_prone_core:2.50.0'
errorprone 'com.uber.nullaway:nullaway:0.13.8'
}
tasks.withType(JavaCompile).configureEach {
options.errorprone {
option('NullAway:OnlyNullMarked', 'true')
option('NullAway:JSpecifyMode', 'true')
}
options.errorprone.warn('NullAway')
}src/test/java/repro/package-info.java:
@NullMarked
package repro;
import org.jspecify.annotations.NullMarked;src/test/java/repro/Aaa.java — a second compilation unit is required; its contents are not:
package repro;
class Aaa {
}src/test/java/repro/Bbb.java — the trigger:
package repro;
import java.util.function.Consumer;
import java.util.function.Function;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertThrows;
class Bbb {
record Attr(String name, String value) {
}
record Tag(String code) {
}
interface Box<T> {
}
static class MapperException extends Exception {
}
static class Ctx {
abstract static class Builder<C extends Ctx, B extends Builder<C, B>> {
abstract B self();
B id(long id) {
return self();
}
B attribute(Attr a) {
return self();
}
}
}
static class DomainException extends RuntimeException {
static DomainException notValid(
Consumer<Ctx.Builder<?, ? extends Ctx.Builder<?, ?>>> contextCustomizer,
Throwable throwable
) {
throw new AssertionError();
}
}
static class Factory {
<T> Box<T> create(
String name,
String rawValue,
Tag tag,
Function<MapperException, DomainException> exceptionMapper
) {
throw new AssertionError();
}
}
private static final Tag TAG = new Tag("t");
private final Factory factory = new Factory();
void trigger() {
var name = "n";
var value = "v";
var exception = assertThrows(
DomainException.class,
() -> factory.create(name, value, TAG, e -> map(e, name, value))
);
assertInstanceOf(MapperException.class, exception.getCause());
}
private static DomainException map(
MapperException e,
String name,
String value
) {
return DomainException.notValid(
contextCustomizer -> contextCustomizer
.attribute(new Attr(name, value)),
e
);
}
}Run ./gradlew compileTestJava --rerun-tasks.
Stack trace
Verbatim, from the reproducer above (javac reports it twice; this is one copy):
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.NullPointerException: Cannot invoke "javax.lang.model.element.Element.getEnclosingElement()" because "enclosing" is null
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2077)
at com.google.common.cache.LocalCache.get(LocalCache.java:3985)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4006)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4953)
at com.uber.nullaway.dataflow.DataFlow.isRunning(DataFlow.java:346)
at com.uber.nullaway.dataflow.AccessPathNullnessAnalysis.isRunning(AccessPathNullnessAnalysis.java:460)
at com.uber.nullaway.generics.GenericsChecks.updateEnvironmentMappingForLambda(GenericsChecks.java:1606)
at com.uber.nullaway.generics.GenericsChecks.refineArgumentTypeWithDataflow(GenericsChecks.java:1566)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForPseudoAssignment(GenericsChecks.java:1315)
at com.uber.nullaway.generics.GenericsChecks.handleLambdaInGenericMethodInference(GenericsChecks.java:1360)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForPseudoAssignment(GenericsChecks.java:1305)
at com.uber.nullaway.generics.GenericsChecks.lambda$generateConstraintsForCall$0(GenericsChecks.java:1233)
at com.uber.nullaway.InvocationArguments.forEach(InvocationArguments.java:86)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForCall(GenericsChecks.java:1230)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForPseudoAssignment(GenericsChecks.java:1273)
at com.uber.nullaway.generics.GenericsChecks.handleLambdaInGenericMethodInference(GenericsChecks.java:1360)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForPseudoAssignment(GenericsChecks.java:1305)
at com.uber.nullaway.generics.GenericsChecks.lambda$generateConstraintsForCall$0(GenericsChecks.java:1233)
at com.uber.nullaway.InvocationArguments.forEach(InvocationArguments.java:86)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForCall(GenericsChecks.java:1230)
at com.uber.nullaway.generics.GenericsChecks.runInferenceForCall(GenericsChecks.java:1110)
at com.uber.nullaway.generics.GenericsChecks.inferGenericMethodCallType(GenericsChecks.java:1062)
at com.uber.nullaway.generics.GenericsChecks.getTypeForRhsOfAssignment(GenericsChecks.java:995)
at com.uber.nullaway.generics.GenericsChecks.getInferredTypeForVarLocalDeclaration(GenericsChecks.java:969)
at com.uber.nullaway.generics.GenericsChecks.getInferredVarLocalType(GenericsChecks.java:958)
at com.uber.nullaway.generics.GenericsChecks.getTreeType(GenericsChecks.java:669)
at com.uber.nullaway.generics.GenericsChecks.getEnclosingTypeForCallExpression(GenericsChecks.java:2761)
at com.uber.nullaway.generics.GenericsChecks.getTreeType(GenericsChecks.java:706)
at com.uber.nullaway.generics.NestedTypeVarSubstitutionRepairVisitor.repairMethodTypeInternal(NestedTypeVarSubstitutionRepairVisitor.java:133)
at com.uber.nullaway.generics.NestedTypeVarSubstitutionRepairVisitor.repairMethodType(NestedTypeVarSubstitutionRepairVisitor.java:83)
at com.uber.nullaway.generics.GenericsChecks.restoreNestedNullabilityForTypeVarArguments(GenericsChecks.java:2519)
at com.uber.nullaway.generics.GenericsChecks.substituteTypeArgsInGenericMethodType(GenericsChecks.java:2483)
at com.uber.nullaway.generics.GenericsChecks.getGenericReturnNullnessAtInvocation(GenericsChecks.java:2406)
at com.uber.nullaway.dataflow.AccessPathNullnessPropagation.genericReturnIsNullable(AccessPathNullnessPropagation.java:1168)
at com.uber.nullaway.dataflow.AccessPathNullnessPropagation.returnValueNullness(AccessPathNullnessPropagation.java:1145)
at com.uber.nullaway.dataflow.AccessPathNullnessPropagation.visitMethodInvocation(AccessPathNullnessPropagation.java:1054)
at com.uber.nullaway.dataflow.AccessPathNullnessPropagation.visitMethodInvocation(AccessPathNullnessPropagation.java:148)
at org.checkerframework.nullaway.dataflow.cfg.node.MethodInvocationNode.accept(MethodInvocationNode.java:154)
at org.checkerframework.nullaway.dataflow.analysis.AbstractAnalysis.callTransferFunction(AbstractAnalysis.java:501)
at org.checkerframework.nullaway.dataflow.analysis.ForwardAnalysisImpl.callTransferFunction(ForwardAnalysisImpl.java:383)
at org.checkerframework.nullaway.dataflow.analysis.ForwardAnalysisImpl.performAnalysisBlock(ForwardAnalysisImpl.java:151)
at org.checkerframework.nullaway.dataflow.analysis.ForwardAnalysisImpl.performAnalysis(ForwardAnalysisImpl.java:105)
at com.uber.nullaway.dataflow.RunOnceForwardAnalysisImpl.performAnalysis(RunOnceForwardAnalysisImpl.java:33)
at com.uber.nullaway.dataflow.DataFlow.dataflow(DataFlow.java:160)
at com.uber.nullaway.dataflow.DataFlow.resultFor(DataFlow.java:326)
at com.uber.nullaway.dataflow.DataFlow.resultForExpr(DataFlow.java:304)
at com.uber.nullaway.dataflow.DataFlow.expressionDataflow(DataFlow.java:227)
at com.uber.nullaway.dataflow.AccessPathNullnessAnalysis.getNullness(AccessPathNullnessAnalysis.java:119)
at com.uber.nullaway.generics.GenericsChecks.refineArgumentTypeWithDataflow(GenericsChecks.java:1576)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForPseudoAssignment(GenericsChecks.java:1315)
at com.uber.nullaway.generics.GenericsChecks.lambda$generateConstraintsForCall$0(GenericsChecks.java:1233)
at com.uber.nullaway.InvocationArguments.forEach(InvocationArguments.java:86)
at com.uber.nullaway.generics.GenericsChecks.generateConstraintsForCall(GenericsChecks.java:1230)
at com.uber.nullaway.generics.GenericsChecks.runInferenceForCall(GenericsChecks.java:1110)
at com.uber.nullaway.generics.GenericsChecks.inferGenericMethodCallType(GenericsChecks.java:1062)
at com.uber.nullaway.generics.GenericsChecks.getTypeForRhsOfAssignment(GenericsChecks.java:995)
at com.uber.nullaway.generics.GenericsChecks.getInferredTypeForVarLocalDeclaration(GenericsChecks.java:969)
at com.uber.nullaway.generics.GenericsChecks.checkTypeParameterNullnessForAssignability(GenericsChecks.java:892)
at com.uber.nullaway.NullAway.matchVariable(NullAway.java:1677)
at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:541)
at com.google.errorprone.scanner.ErrorProneScanner.visitVariable(ErrorProneScanner.java:1093)
at com.google.errorprone.scanner.ErrorProneScanner.visitVariable(ErrorProneScanner.java:180)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:1084)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:95)
at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
at jdk.compiler/com.sun.source.util.TreeScanner.visitBlock(TreeScanner.java:271)
at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:623)
at com.google.errorprone.scanner.ErrorProneScanner.visitBlock(ErrorProneScanner.java:180)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1148)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:95)
at jdk.compiler/com.sun.source.util.TreeScanner.visitMethod(TreeScanner.java:223)
at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:884)
at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:180)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:992)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:95)
at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:118)
at jdk.compiler/com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:202)
at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:651)
at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:180)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:899)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:110)
at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:118)
at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:151)
at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:663)
at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:180)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:627)
at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:66)
at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:231)
at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:133)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1423)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1370)
at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:955)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:152)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at org.gradle.internal.compiler.java.IncrementalCompileTask.call(IncrementalCompileTask.java:92)
at org.gradle.api.internal.tasks.compile.AnnotationProcessingCompileTask.call(AnnotationProcessingCompileTask.java:94)
at org.gradle.api.internal.tasks.compile.ResourceCleaningCompilationTask.call(ResourceCleaningCompilationTask.java:57)
at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:82)
at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:49)
at org.gradle.api.internal.tasks.compile.daemon.CompilerWorkAction.execute(CompilerWorkAction.java:52)
at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:68)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:54)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:48)
at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:102)
at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:48)
at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:32)
at org.gradle.workers.internal.FlatClassLoaderWorker.run(FlatClassLoaderWorker.java:22)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:108)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:77)
at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$1(WorkerAction.java:150)
at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
at org.gradle.process.internal.worker.request.WorkerAction.lambda$run$2(WorkerAction.java:150)
at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:84)
at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:142)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at org.gradle.internal.dispatch.MethodInvocation.invokeOn(MethodInvocation.java:77)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:28)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:19)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:47)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
at java.base/java.lang.Thread.run(Thread.java:1474)
Caused by: java.lang.NullPointerException: Cannot invoke "javax.lang.model.element.Element.getEnclosingElement()" because "enclosing" is null
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.getReceiver(CFGTranslationPhaseOne.java:3499)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.visitIdentifier(CFGTranslationPhaseOne.java:4301)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.visitIdentifier(CFGTranslationPhaseOne.java:212)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCIdent.accept(JCTree.java:2718)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.scan(CFGTranslationPhaseOne.java:577)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.getReceiver(CFGTranslationPhaseOne.java:3480)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.visitMethodInvocation(CFGTranslationPhaseOne.java:3239)
at com.uber.nullaway.dataflow.cfg.NullAwayCFGBuilder$NullAwayCFGTranslationPhaseOne.visitMethodInvocation(NullAwayCFGBuilder.java:227)
at com.uber.nullaway.dataflow.cfg.NullAwayCFGBuilder$NullAwayCFGTranslationPhaseOne.visitMethodInvocation(NullAwayCFGBuilder.java:92)
at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodInvocation.accept(JCTree.java:1876)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.scan(CFGTranslationPhaseOne.java:577)
at org.checkerframework.nullaway.dataflow.cfg.builder.CFGTranslationPhaseOne.process(CFGTranslationPhaseOne.java:479)
at com.uber.nullaway.dataflow.cfg.NullAwayCFGBuilder.build(NullAwayCFGBuilder.java:81)
at com.uber.nullaway.dataflow.DataFlow$2.load(DataFlow.java:129)
at com.uber.nullaway.dataflow.DataFlow$2.load(DataFlow.java:97)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3556)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2307)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2180)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2071)
... 144 more
Conditions (each verified necessary by removing it)
-
NullAway:JSpecifyMode=true. With it off, clean. -
JUnit 6, not JUnit 5. Identical sources on
junit-jupiter-api:5.11.4are clean;6.0.3
crashes. JUnit 6 is JSpecify-annotated, soassertThrows's signature goes through the
generic-inference path. -
A second compilation unit in the same batch. Deleting
Aaa.javamakes it clean; its contents
are irrelevant (an empty class suffices). -
The second file's name. With byte-identical contents, only the file name changed:
Aaa.java,Abc.javaandMmm.javareproduce, whileA.java,Ab.javaandZzz.javado not.
NoteA.javaandAaa.javaoccupy the same position in any ordering of the batch, so this is not
a simple source-order rule — it looks like sensitivity to which entries happen to be resident in
cfgCachewhen the faulty lookup happens (see below). Renaming the trigger file does not matter:
it still crashes asZzz.java.This fragility is worth keeping in mind when reducing the case further — a change that "fixes" it
may only have perturbed cache residency.
Possible cause
The trace shows re-entrant dataflow. Reading it bottom-up: NullAway.matchVariable starts
generic-method inference for the var exception = assertThrows(...) declaration;
GenericsChecks.refineArgumentTypeWithDataflow (frame 51) asks for the nullness of an argument via
AccessPathNullnessAnalysis.getNullness, which starts a dataflow run; inside that run,
AccessPathNullnessPropagation.visitMethodInvocation needs a generic return type, which re-enters
GenericsChecks inference (frames 29-38) and reaches
handleLambdaInGenericMethodInference → refineArgumentTypeWithDataflow again (frame 10) →
updateEnvironmentMappingForLambda → AccessPathNullnessAnalysis.isRunning → DataFlow.isRunning.
DataFlow.isRunning does cfgCache.getUnchecked(CfgParams.create(path, env)), i.e. it builds a
CFG on a miss rather than only inspecting already-running analyses. The path it is given comes from
refineArgumentTypeWithDataflow's pathWithLeaf, whose own comment notes the result "may not
actually be the valid tree path to the expression". Building a CFG from that synthesized path then
walks a method invocation whose receiver is an identifier requiring an implicit this, and
CFGTranslationPhaseOne.getReceiver NPEs because the enclosing element cannot be resolved.
That fits the observed fragility: cfgCache is a maximumSize(MAX_CACHE_SIZE = 50) LRU, so whether
this lookup is a hit (harmless) or a miss (crash) depends on what else was analysed first — which is
why an unrelated empty second file, and even its name, changes the outcome.
The enclosingPath == null / methodEnclosingLambda == null guards in
updateEnvironmentMappingForLambda don't cover a lambda whose enclosing element isn't resolvable
from the synthesized path. isRunning querying a cache that constructs on miss also looks
questionable for a recursion check.
Activity
msridhar commentedon Aug 7, 2026
Thanks for the detailed report! Looking into this
msridhar commentedon Aug 7, 2026
Thanks again for the reduced test. This exposed a very subtle bug in our code. We'll do an immediate fix and then some follow-up fixes to robustify the related code. I'm pasting a rough plan from Codex below.
Issue 1680 Fix Plan
GitHub issue: #1680
Root cause
AccessPathNullnessAnalysisis a singleton for a javac context. When it constructsAccessPathNullnessPropagation, it stores theVisitorStatefrom whichever compilation unit wasbeing visited at the time. In the reproducer, that state points into
Aaa.java.Later, dataflow analyzes CFG nodes from
Bbb.java.AccessPathNullnessPropagationpasses both theCFG node's correct
TreePathand its stored, staleVisitorStateinto generic inference:The explicit path is initially correct, but it is dropped before nested type-variable substitution
repair.
NestedTypeVarSubstitutionRepairVisitorreconstructs a path fromstate.getPath(), therebyattaching a
Bbbinvocation beneath theAaaclass. On-demand inference for thevarlocalexceptionextends this malformed path further with theassertThrowsinitializer and its nestedlambdas.
Lambda environment setup eventually calls
DataFlow.isRunning()with the cross-compilation-unitpath.
isRunning()usescfgCache.getUnchecked(...), which constructs a CFG on a cache miss. Whilebuilding the CFG for
factory.create(...), the Checker Framework tries to resolve the implicitthisreceiver of theBbb.factoryfield usingAaaas the enclosing class. Its enclosing-elementsearch reaches
null, causing the reportedNullPointerException.The otherwise unused
Aaa.javais relevant because it determines the path stored in the long-livedVisitorState; it is not needed to fill or evict the 50-entry CFG cache.Planned fixes
1. Rebase state at the dataflow-to-generics boundary
In
AccessPathNullnessPropagation.genericReturnIsNullable(), pass a state whose path matches thecurrent CFG node:
This change has been tested experimentally and removes the NPE.
2. Preserve explicit paths through nested type repair
Thread the invocation
TreePaththroughGenericsChecks.restoreNestedNullabilityForTypeVarArguments()andNestedTypeVarSubstitutionRepairVisitor. The repair visitor should use the explicit path instead ofreconstructing it from
state.getPath().This is defense in depth alongside step 1: APIs that already accept a relevant path should not drop
it and later recover it from a possibly unrelated
VisitorState.3. Audit uses of the stored
VisitorStateAudit every place where
AccessPathNullnessPropagation.stateescapes to another component, notjust direct calls to
state.getPath().Initial findings:
Context,Types, or symbol utilities and are path-independent.GenericsChecksis the demonstrated unsafe flow.Handler.onDataflowVisitMethodInvocation(...)receives the stored state. Rebase it tonode.getTreePath()before invoking handlers so the API actually receives the documented"current" state.
Handler.onDataflowVisitReturn(...)also receives the stored state. Current handlers do notappear to depend on its path, but
ReturnNodedoes not expose aTreePath, so a systematic fixmay require an API or CFG integration change.
state.getSourceForNode(...)may use the wrong compilation unit.This is lower severity but should be corrected when a node path is available.
Consider a longer-term refactoring that removes the long-lived
VisitorStatefield. Store onlypath-independent services such as
ContextandTypes, and require an explicit current path forpath-sensitive operations.
4. Make
varinitializer paths structurally validGenericsChecks.getInferredVarLocalType()currently constructs an initializer path with:Even after step 1, this attaches the declaration's initializer beneath a use of the variable. It
stays within the correct compilation unit, but it is not a real AST parent-child path.
Investigate caching the declaration's real
TreePath, or recovering that path from its compilationunit when on-demand inference is required. This is related correctness hardening, but it need not
block the direct crash fix if the broader change is invasive.
5. Make
DataFlow.isRunning()a pure query in a follow-upisRunning()should ideally inspect existing state without constructing a CFG or analysis. This isnot the root cause of issue #1680, and changing it alone would not make malformed paths valid.
This cleanup requires care:
CfgParamscurrently usesTreePathequality. Independently reconstructed paths may not match anexisting cache key even when they identify the same method or lambda.
dataflow.
initializer tree—rather than by a particular
TreePathinstance.Treat this as a separate change with focused recursion and cache tests.
Fix subtle issue with invalid TreePaths (#1681)
Defensively thread path into NestedTypeVarSubstitutionRepairVisitor (#…
More TreePath hardening (#1684)
Attribute errors reported during dataflow to the right file