[msridhar]

We should test that this passes once we get the JSpecify JDK models in (#950)

Summary by CodeRabbit

• Tests
  • Added test case to validate proper null-safety handling for nullable parameters with default values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7df3529e-ce44-41dc-b344-4a42b0ddba16

📥 Commits

Reviewing files that changed from the base of the PR and between c85b66e and b96862e.

📒 Files selected for processing (1)

• nullaway/src/test/java/com/uber/nullaway/jspecify/GenericMethodTests.java

---

Walkthrough

A new test method issue1493 was added to the GenericMethodTests class. The test is currently disabled via @Ignore annotation and verifies behavior related to Objects.requireNonNullElse invocation. The test code includes a @NullMarked class that passes a @Nullable string parameter alongside a non-annotated default value to the utility method, then executes the test via .doTest().

Possibly related PRs

• PR #1471: Addresses generic-method nullability inference specifically for the Objects.requireNonNullElse case that this test exercises
• PR #1289: Adds similarly-structured JSpecify inference test methods to GenericMethodTests using the same makeHelperWithInferenceFailureWarning pattern

Suggested reviewers

• lazaroclapp
• yuxincs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test case for issue 1493' directly and clearly describes the main change: adding a test case for a specific issue.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-1493

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (c85b66e) to head (b96862e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1496   +/-   ##
=========================================
  Coverage     88.43%   88.43%           
  Complexity     2790     2790           
=========================================
  Files            99       99           
  Lines          9279     9279           
  Branches       1872     1872           
=========================================
  Hits           8206     8206           
  Misses          524      524           
  Partials        549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.