Repository navigation
Revert "Report error when @Initializer is used on a constructor (#1546)" - #1588
Conversation
This reverts commit 661f374.
|
This change is part of the following stack: Change managed by git-spice. |
WalkthroughThis PR removes a validation check in the Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1588 +/- ##
============================================
- Coverage 88.12% 88.12% -0.01%
+ Complexity 3003 3001 -2
============================================
Files 105 105
Lines 9956 9952 -4
Branches 2022 2021 -1
============================================
- Hits 8774 8770 -4
Misses 565 565
Partials 617 617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 661f374.
It turns out there are valid scenarios for
@Autowiredto be written on a constructor (to disambiguate when multiple constructors are present). In general, we don't know what other purposes custom initializer annotations are being used for, beyond initialization semantics. So, let's not warn when they are used on constructors.