You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add library model for Guava's Closer.register - #632
This is a follow up to #628 and our support for @ParametricNullness in NullAway 0.9.9.
It turns out that com.google.common.io.Closer annotates it's register method as:
@CanIgnoreReturnValue
@ParametricNullness
public <C extends @Nullable Closeable> C register(@ParametricNullness C closeable) {...}
Where the return is only really @Nullable if the argument is @Nullable (it is the same reference).
This PR adds a Library Model for this method, which is equivalent to adding the @Contract("null -> null")
annotation to it.
Note that, in order for this model to be helpful, AcknowledgeLibraryModelsOfAnnotatedCode
must be set, which would seem to argue for making that the default.
Note that, in order for this model to be helpful, AcknowledgeLibraryModelsOfAnnotatedCode
must be set, which would seem to argue for making that the default.
Maybe we should just get rid of the flag entirely? I'm not sure how likely it is that a user will have a library model for annotated code and will prefer the annotations in the code. I'm also fine with turning the flag on by default if we want to preserve the option.
Note that, in order for this model to be helpful, AcknowledgeLibraryModelsOfAnnotatedCode
must be set, which would seem to argue for making that the default.
Maybe we should just get rid of the flag entirely? I'm not sure how likely it is that a user will have a library model for annotated code and will prefer the annotations in the code. I'm also fine with turning the flag on by default if we want to preserve the option.
I think for next release we should keep the flag and just flip the default just in case. I do worry that we will forget and never remove the flag, though... in either case, will make that as a separate PR if only for better Changelog tracking π
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #628 and our support for
@ParametricNullnessin NullAway 0.9.9.It turns out that
com.google.common.io.Closerannotates it'sregistermethod as:Where the return is only really
@Nullableif the argument is@Nullable(it is the same reference).This PR adds a Library Model for this method, which is equivalent to adding the
@Contract("null -> null")annotation to it.
Note that, in order for this model to be helpful,
AcknowledgeLibraryModelsOfAnnotatedCodemust be set, which would seem to argue for making that the default.