Skip to content

[UNDERTOW-2371] initialize the DefaultServer once to speed up test HttpContinueSslServletTestCase - #1574

Merged
baranowb merged 1 commit into
undertow-io:mainfrom
TestBoost:master
Nov 26, 2024
Merged

baranowb merged 1 commit into
undertow-io:mainfrom
TestBoost:master

Conversation

@TestBoost

@TestBoost TestBoost commented Apr 3, 2024 •

Copy link
Copy Markdown
Contributor

There are five tests in the test class HttpContinueSslServletTestCase. However, they reply on the same DefaultServer to send post http request. The time cost of start or stop for the DefaultServer is high. They are not modifying the contents of the DefaultServer, thus we can just initialize the DefaultServer once before or after all test methods inside test class HttpContinueSslServletTestCase.

The test runtime can jump from 5.43160 s to 1.8027 s after applying these changes when run on our machine.

Jira: https://issues.redhat.com/browse/UNDERTOW-2371

2.2.x PR: #1751
2.3.x PR: #1752

@baranowb

baranowb commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

@TestBoost Could you please create a ticket?

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check labels Apr 3, 2024
@TestBoost TestBoost changed the title initialize the DefaultServer once to speed up test HttpContinueSslServletTestCase [UNDERTOW-2371] initialize the DefaultServer once to speed up test HttpContinueSslServletTestCase Apr 3, 2024
@TestBoost

Copy link
Copy Markdown
Contributor Author

Sure, I just submit a ticket here https://issues.redhat.com/browse/UNDERTOW-2371. I don't know why the test class Http2ClientTestCase fails because the DefaultServer is already closed. Maybe we also need some checks in the test Http2ClientTestCase too.

@baranowb baranowb added the waiting PR update Awaiting PR update(s) from contributor before merging label May 6, 2024
@baranowb baranowb added the failed CI Introduced new regession(s) during CI check label Jun 24, 2024
@baranowb

Copy link
Copy Markdown
Contributor

@TestBoost could you please force push again to trigger CI?

@ropalka
ropalka requested a review from baranowb August 7, 2024 10:15

@baranowb baranowb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If marked method is not used, it should be removed?


@Before
public void before() throws Exception {
public static void before() throws Exception {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method even used now?

…tpContinueSslServletTestCase

Signed-off-by: Flavia Rainone <frainone@redhat.com>
@baranowb baranowb removed the failed CI Introduced new regession(s) during CI check label Nov 26, 2024
@baranowb
baranowb merged commit 4577d88 into undertow-io:main Nov 26, 2024
@baranowb baranowb added next release This PR will be merged before next release or has already been merged (for payload double check) and removed waiting PR update Awaiting PR update(s) from contributor before merging under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check labels Nov 26, 2024
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances existing behaviour or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants