Repository navigation
test: enable HMR dependency acceptance coverage for webpack - #101196
Merged
mischnic merged 2 commits intoNov 6, 2026
Merged
Conversation
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
Contributor
Tests PassedCommit: 9786b5a |
mischnic
marked this pull request as ready for review
November 5, 2026 10:40
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
bgw
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #101195.
Enable all five HMR dependency accept/decline tests for both Webpack and Turbopack without bundler-specific gates. The ESM fixtures now register the equivalent
import.meta.webpackHotcalls alongsideimport.meta.turbopackHot; the CommonJS fixture already works with both bundlers. Thetest/development/directory already limits the suite to development mode, so no explicit development gate is needed.Strengthen the decline tests to verify that window state is cleared, distinguishing a full page reload from Fast Refresh.
Verification