Skip to content

test: enable HMR dependency acceptance coverage for webpack - #101196

Merged
mischnic merged 2 commits into
mischnic/tests-turbopack-gatefrom
fleet/hmr-dep-accept-parity
Nov 6, 2026
Merged

mischnic merged 2 commits into
mischnic/tests-turbopack-gatefrom
fleet/hmr-dep-accept-parity

Conversation

@mischnic

@mischnic mischnic commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Stacked on #101195.

Enable all five HMR dependency accept/decline tests for both Webpack and Turbopack without bundler-specific gates. The ESM fixtures now register the equivalent import.meta.webpackHot calls alongside import.meta.turbopackHot; the CommonJS fixture already works with both bundlers. The test/development/ directory already limits the suite to development mode, so no explicit development gate is needed.

Strengthen the decline tests to verify that window state is cleared, distinguishing a full page reload from Fast Refresh.

Verification

  • All five cases pass with both bundlers.
  • TypeScript, ESLint, and Prettier checks pass.

Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
@github-actions github-actions Bot added created-by: Turbopack team PRs by the Turbopack team. tests labels Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 9786b5a

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel Agent reviewed 5ce9970 and found no issues.

@mischnic
mischnic added this pull request to stack #101197 November 5, 2026 10:37
@mischnic
mischnic marked this pull request as ready for review November 5, 2026 10:40
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel Agent reviewed 9786b5a and found no issues.

@mischnic
mischnic merged commit 2d8a09e into canary Nov 6, 2026
232 of 234 checks passed
@mischnic
mischnic deleted the fleet/hmr-dep-accept-parity branch November 6, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants