Repository navigation
Use forward slashes in route bundle stats chunk paths - #101617
Merged
Merged
Conversation
Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Contributor
Tests PassedCommit: 0fbadd5 |
github-actions
Bot
added
created-by: Turbopack team
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
.next/diagnostics/route-bundle-stats.jsonnow always listsfirstLoadChunkPathswith forward slashes, on every platform.Why?
The paths came from
path.relative/path.join, so on Windows they used backslashes (.next\static\chunks\…). This wasn't intentional: it makes the file platform-dependent. Output on Linux and macOS is unchanged.This is the base of #101540, which computes the same file in Turbopack and should produce identical output on every platform.
How?
toProjectRelativePathsinpackages/next/src/build/route-bundle-stats.tsreplacespath.sepwith/. The production test now asserts/-separated paths and no backslashes.Verification
test/production/route-bundle-stats(Turbopack, start mode) passes with Cache Components on and off.