Repository navigation
Conversation
Member
|
Reviewing this. Could you please remove the Closes claim though? I don't think it is sufficient. We need to make a statement on that issue too. |
icyJoseph
reviewed
Sep 21, 2026
icyJoseph
reviewed
Sep 21, 2026
Contributor
Author
|
Done, it's Refs #63657 now and I left a note on the issue. |
…hook Show the custom metrics accessed via the reportWebVitals export from pages/_app rather than the useReportWebVitals hook. Also remove "custom performance metrics" from the Pages router reference description and fix a broken bracket syntax error (} instead of })) in the Google Analytics sample on the same page.
Custom metrics only reach the reportWebVitals export from pages/_app, and Web Vitals only reach the useReportWebVitals hook, so show both entry points used together instead of replacing one with the other. Update both page descriptions to highlight the difference.
adityareddy-dev
force-pushed
the
docs/use-report-web-vitals-custom-metrics
branch
from
September 25, 2026 05:09
9b5baed to
0fcc18b
Compare
Contributor
Author
|
@icyJoseph both review threads are resolved, and the example now shows the hook and export together. Could you take another look and approve the workflow run? It still shows |
Member
|
Awesome, sorry I had to take a pause the last couple of weeks. Just catching up with PRs and stuff. |
adityareddy-dev
changed the title
Contributor
Author
|
@icyJoseph could you check why the build-and-test run failed before creating any jobs? |
Member
|
The checks don't run for all PRs, it has to be allowed to run. I'll pick this up soon. |
icyJoseph
reviewed
Nov 10, 2026
Core Web Vitals are LCP, CLS and INP. List FCP and TTFB as the extra metrics the hook also reports.
adityareddy-dev
force-pushed
the
docs/use-report-web-vitals-custom-metrics
branch
from
November 10, 2026 23:32
7a75f8d to
0fcc18b
Compare
github-actions
Bot
added
the
Documentation
icyJoseph
approved these changes
Nov 11, 2026
Contributor
Tests PassedCommit: 231b5e7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
useReportWebVitalsgets the Web Vitals and thereportWebVitalsexport frompages/_appgets the Next.js custom metrics, so the docs now show both in onepages/_appexample. Also updated both page descriptions and fixed a missing closing parenthesis in the Google Analytics sample.Why
The page read like one replaces the other, but each one only gets its own set of metrics.
Refs #63657
Checklist