Skip to content

Factor out method to get resolved TaskDefinition - #3378

Merged
mehulkar merged 2 commits into
mainfrom
mk/pt-refactor
Jan 20, 2023
Merged

mehulkar merged 2 commits into
mainfrom
mk/pt-refactor

Conversation

@mehulkar

Copy link
Copy Markdown
Contributor

The way we resolve a taskDefinition will change
once we start allowing workspaces to create their own config so it makes sense to factor this method out first.

@vercel

vercel Bot commented Jan 19, 2023 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
examples-native-web πŸ”„ Building (Inspect) Visit Preview Jan 20, 2023 at 6:17AM (UTC)
turbo-vite-web πŸ”„ Building (Inspect) Jan 20, 2023 at 6:17AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:17AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2023 at 6:17AM (UTC)

@github-actions

github-actions Bot commented Jan 19, 2023 •

Copy link
Copy Markdown
Contributor

🟒 CI successful 🟒

Thanks

@mehulkar
mehulkar marked this pull request as ready for review January 19, 2023 09:08
@mehulkar
mehulkar requested a review from a team as a code owner January 19, 2023 09:08
// defined in the Graph. Later, this will get Pipelines defined in the task's workspace as well.
func (g *CompleteGraph) getResolvedTaskDefinition(taskID string, taskName string) (*fs.TaskDefinition, error) {
return getTaskFromPipeline(g.Pipeline, taskID, taskName)
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we'll implement the magic in #2706

The way we resolve a taskDefinition will change
once we start allowing workspaces to create their own config
so it makes sense to factor this method out first.

@nathanhammond nathanhammond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we won't want to pre-resolve everything before getting here, but this doesn't materially change anything and seems fine.

@mehulkar

Copy link
Copy Markdown
Contributor Author

I'm not convinced we won't want to pre-resolve everything before getting here

Let's chat about that, considering the other conversation we had today about pre-calculated task hashes as well. Want to make sure I'm not overlooking anything.

@mehulkar
mehulkar enabled auto-merge (squash) January 20, 2023 06:16
@mehulkar
mehulkar merged commit 552768b into main Jan 20, 2023
@mehulkar
mehulkar deleted the mk/pt-refactor branch January 20, 2023 06:30
@mehulkar mehulkar mentioned this pull request Feb 6, 2023
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants