Skip to content

Allow overriding persistent flag from workspace - #3730

Merged
mehulkar merged 2 commits into
mehulkar/turbo-538-composable-turbojsonfrom
mehulkar/turbo-778-overriding-persistent-field-from
Feb 10, 2023
Merged

mehulkar merged 2 commits into
mehulkar/turbo-538-composable-turbojsonfrom
mehulkar/turbo-778-overriding-persistent-field-from

Conversation

@mehulkar

@mehulkar mehulkar commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

Will do cache key next

@ghost ghost added the team: turborepo label Feb 10, 2023
@vercel

vercel Bot commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
examples-native-web πŸ”„ Building (Inspect) Feb 10, 2023 at 1:56AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Feb 10, 2023 at 1:56AM (UTC)

@mehulkar
mehulkar marked this pull request as ready for review February 10, 2023 01:41
@mehulkar
mehulkar requested a review from a team as a code owner February 10, 2023 01:42
@mehulkar
mehulkar requested review from NicholasLYang and tknickman and removed request for a team February 10, 2023 01:42

// An error here means turbo.json exists, but didn't define the task.
// Fallback to the root pipeline to find the task.
if pkg != util.RootPkgName {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this condition wasn't exercised by any of the other tests yet... something about #3729 caused this change, because the refactor returned empty structs in some cases rather than throwing errors.

@socket-security

Copy link
Copy Markdown

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

πŸ“œ Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@sveltejs/kit@1.5.3 (upgraded) postinstall examples/with-svelte/apps/docs/package.json via @sveltejs/adapter-auto@2.0.0, examples/with-svelte/apps/web/package.json via @sveltejs/adapter-auto@2.0.0
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code βœ… 0 issues
Bin script confusion βœ… 0 issues
Bin script shell injection βœ… 0 issues
Unresolved require βœ… 0 issues
Invalid package.json βœ… 0 issues
HTTP dependency βœ… 0 issues
Git dependency βœ… 0 issues
Potential typo squat βœ… 0 issues
Known Malware βœ… 0 issues
Telemetry βœ… 0 issues
Protestware/Troll package βœ… 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore @sveltejs/kit@1.5.3

Powered by socket.dev

@github-actions

github-actions Bot commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

🟒 CI successful 🟒

Thanks

@mehulkar
mehulkar merged commit 14e3dc6 into mehulkar/turbo-538-composable-turbojson Feb 10, 2023
@mehulkar
mehulkar deleted the mehulkar/turbo-778-overriding-persistent-field-from branch February 10, 2023 05:05
@mehulkar mehulkar mentioned this pull request Feb 10, 2023
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant