Skip to content

Detect invalid workspace turbo.json configurations - #3749

Merged
mehulkar merged 12 commits into
mehulkar/turbo-538-composable-turbojsonfrom
mehulkar/turbo-777-prevent-packagetask-syntax-in-workspace
Feb 11, 2023
Merged

mehulkar merged 12 commits into
mehulkar/turbo-538-composable-turbojsonfrom
mehulkar/turbo-777-prevent-packagetask-syntax-in-workspace

Conversation

@mehulkar

@mehulkar mehulkar commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

Adds a generic way to validate. I made it generic because I anticipate that

  1. we will want a different set of validations for the root config
  2. In this case, the end-user error I want to print which config we're talking about the fs.TurboJSON doesn't actually know that. Generally, the outer context will know what the validation error means and how to present it to the user.

@vercel

vercel Bot commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
examples-tailwind-web πŸ”„ Building (Inspect) Feb 11, 2023 at 0:51AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 11, 2023 at 0:51AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2023 at 0:51AM (UTC)

@socket-security

This comment was marked as off-topic.

@mehulkar
mehulkar marked this pull request as ready for review February 10, 2023 21:52
@mehulkar
mehulkar requested a review from a team as a code owner February 10, 2023 21:52
@mehulkar
mehulkar requested review from chris-olszewski, gsoltis and tknickman and removed request for a team February 10, 2023 21:52
Comment thread cli/internal/core/engine.go Resolved
@github-actions

github-actions Bot commented Feb 10, 2023 •

Copy link
Copy Markdown
Contributor

🟒 CI successful 🟒

Thanks

@mehulkar
mehulkar force-pushed the mehulkar/turbo-777-prevent-packagetask-syntax-in-workspace branch from 7e17a1d to 98f5993 Compare February 10, 2023 23:33
@mehulkar mehulkar changed the title Detect when package#task syntax is declared in workspace config Detect invalid workspace turbo.json configurations Feb 11, 2023
@mehulkar
mehulkar requested a review from gsoltis February 11, 2023 00:20
@mehulkar

This comment was marked as resolved.

@mehulkar
mehulkar merged commit f44f24f into mehulkar/turbo-538-composable-turbojson Feb 11, 2023
@mehulkar
mehulkar deleted the mehulkar/turbo-777-prevent-packagetask-syntax-in-workspace branch February 11, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants