Repository navigation
[sglang] fix: only wake up weights on infer_tp 0 - #2403
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a bug fix in the FSDPSGLangShardingManager. The change ensures that resuming memory occupation for the KV cache during the multi-stage wake-up process is only performed on rank 0 of the inference tensor parallelism group. This aligns with the existing logic for other inference engine operations, preventing potential race conditions or redundant operations across multiple ranks. The change is correct and improves the robustness of the distributed setup.
hebiao064
left a comment
There was a problem hiding this comment.
I've fixed in my PR: https://github.com/volcengine/verl/pull/2187/files#diff-5872c25af9ac22eee90d7163b2e9efdce7ef2c1f1c0293590ad58ad88b497a05
But feel free to merge your fix first since my PR is still blocked by CI
What does this PR do?
As the name goes, a quick bug fix.
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace.