Repository navigation
[cfg] fix: add rollout_correcton config field with omegaconf.open_dict - #4167
Merged
tongyx361 merged 3 commits intoNov 17, 2025
Merged
Conversation
tongyx361
requested review from
PeterSH6,
eric-haibin-lin and
vermouth1992
as code owners
November 17, 2025 14:05
tongyx361
enabled auto-merge (squash)
November 17, 2025 14:06
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces minor but important changes related to configuration handling. It correctly adds multi_turn and temperature parameters to the batch.meta_info for actor updates. More significantly, it addresses a potential runtime error by wrapping the assignment of rollout_correction to policy_loss_config within an omegaconf.open_dict context, ensuring that the configuration can be modified even when in struct mode. The local import of open_dict in rollout_corr_helper.py is also a good practice for modularity. Overall, the changes improve the robustness and correctness of the configuration management.
szrlee
approved these changes
Nov 17, 2025
vermouth1992
approved these changes
Nov 17, 2025
chenhaiq
pushed a commit
to The-Hierophant/verl-1
that referenced
this pull request
Nov 18, 2025
…dict` (verl-project#4167) ### What does this PR do? This PRs fixes adding `rollout_correcton` config field with `omegaconf.open_dict`. ### Test See the CI. Also tested with internal run.
1 of 4 tasks
wuwendyy
pushed a commit
to wuwendyy/verl
that referenced
this pull request
Nov 19, 2025
…dict` (verl-project#4167) ### What does this PR do? This PRs fixes adding `rollout_correcton` config field with `omegaconf.open_dict`. ### Test See the CI. Also tested with internal run.
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
…dict` (verl-project#4167) ### What does this PR do? This PRs fixes adding `rollout_correcton` config field with `omegaconf.open_dict`. ### Test See the CI. Also tested with internal run.
mgilmore-relace
added a commit
to mgilmore-relace/verl
that referenced
this pull request
Dec 20, 2025
vyomakesh0728
added a commit
to vyomakesh0728/verl
that referenced
this pull request
Jan 22, 2026
…dict` (verl-project#4167) ### What does this PR do? This PRs fixes adding `rollout_correcton` config field with `omegaconf.open_dict`. ### Test See the CI. Also tested with internal run.
zwluestc
pushed a commit
to zwluestc/verl
that referenced
this pull request
May 12, 2026
…dict` (verl-project#4167) ### What does this PR do? This PRs fixes adding `rollout_correcton` config field with `omegaconf.open_dict`. ### Test See the CI. Also tested with internal run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PRs fixes adding
rollout_correctonconfig field withomegaconf.open_dict.Test
See the CI. Also tested with internal run.